Warn unused trait imports, rebased #33091

sanxiyn · 2016-04-19T13:46:53Z

Rebase of #30021.

rust-highfive · 2016-04-19T13:47:05Z

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2016-04-19T15:05:35Z

☔ The latest upstream changes (presumably #33002) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2016-04-20T00:16:38Z

r+ with a rebase

sanxiyn · 2016-04-20T13:22:05Z

Travis failure is legit.

f64::sqrt is defined in std. Since librand is no_std, librand defines its own version in FloatMath trait and imports it. But randtest is not no_std, so FloatMath import is necessary for librand and unused for randtest.

sanxiyn · 2016-04-20T19:41:45Z

Rebased and fixed tests.

nrc · 2016-04-20T22:42:49Z

@bors: r+

bors · 2016-04-20T22:42:50Z

📌 Commit baf2fff has been approved by nrc

bors · 2016-04-21T17:58:08Z

⌛ Testing commit baf2fff with merge 2209876...

bors · 2016-04-21T18:01:06Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-04-21T18:02:46Z

@bors: retry

On Thu, Apr 21, 2016 at 11:01 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3888

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · 2016-04-22T15:20:27Z

⌛ Testing commit baf2fff with merge c148426...

bors · 2016-04-22T15:23:11Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-04-22T16:13:46Z

@bors: retry

On Fri, Apr 22, 2016 at 8:23 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3899

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

Warn unused trait imports, rebased Rebase of rust-lang#30021. Fix rust-lang#25730.

mitaa · 2016-04-23T05:10:05Z

cc #33154

I assume this has something to do with this PR?

C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12:5: 12:20 error: unused import
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12 use io::prelude::*;
                                                                                     ^~~~~~~~~~~~~~~
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283:31: 283:39 note: lint level defined here
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                     ^~~~~~~~

sanxiyn · 2016-04-23T07:23:06Z

Yes, it does. Thanks for noticing.

sanxiyn · 2016-04-23T07:23:22Z

@bors r-

sanxiyn · 2016-04-25T06:31:42Z

@bors r=nrc

bors · 2016-04-25T06:31:43Z

📌 Commit 71f19ba has been approved by nrc

bors · 2016-04-25T09:35:19Z

⌛ Testing commit 71f19ba with merge 2bb7770...

bors · 2016-04-25T10:20:12Z

💔 Test failed - auto-linux-64-cargotest

bluss · 2016-04-25T10:45:36Z

Cargo should not be using deny since that makes it explicitly not forward compatible with lint changes.

@brson can we change cargotest to cap the lint level?

sanxiyn · 2016-04-25T13:47:05Z

We could use RUSTFLAGS. Two problems: first, cargo used by rustbuild at the moment is too old and does not support RUSTFLAGS. Second, setting RUSTFLAGS interferes with running cargo test suite.

bors · 2016-05-06T12:15:53Z

⌛ Testing commit 282afda with merge 4bb89bd...

bors · 2016-05-06T13:07:07Z

💔 Test failed - auto-linux-64-opt-rustbuild

alexcrichton · 2016-05-06T15:53:54Z

@bors: retry

Spurious rbml failure in incremental tests #33435

On Fri, May 6, 2016 at 6:07 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/997

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · 2016-05-06T22:13:03Z

⌛ Testing commit 282afda with merge 2843f13...

bors · 2016-05-06T23:04:54Z

💔 Test failed - auto-linux-64-opt-rustbuild

sanxiyn · 2016-05-07T13:52:29Z

@bors retry

bors · 2016-05-07T14:09:14Z

⌛ Testing commit 282afda with merge 464f387...

bors · 2016-05-07T14:59:27Z

💔 Test failed - auto-linux-64-opt-rustbuild

alexcrichton · 2016-05-07T17:16:25Z

@bors: retry

Spurious rbml failure in incremental tests #33435

On Sat, May 7, 2016 at 7:59 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/1015

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · 2016-05-07T19:23:52Z

⌛ Testing commit 282afda with merge a98ad9f...

bors · 2016-05-07T19:36:16Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-05-08T01:12:57Z

⌛ Testing commit 282afda with merge b4a9f6b...

bors · 2016-05-08T02:02:03Z

💔 Test failed - auto-linux-64-opt-rustbuild

sanxiyn · 2016-05-08T10:08:06Z

@bors retry

bors · 2016-05-08T11:50:28Z

⌛ Testing commit 282afda with merge 8e414e0...

Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

bors · 2016-05-08T13:58:22Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned nrc Apr 19, 2016

sanxiyn force-pushed the unused-trait-import-3 branch from 0d38418 to 6ede0f8 Compare April 20, 2016 15:10

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 22, 2016

Rollup merge of rust-lang#33091 - sanxiyn:unused-trait-import-3, r=nrc

9cdfc10

Warn unused trait imports, rebased Rebase of rust-lang#30021. Fix rust-lang#25730.

Manishearth mentioned this pull request Apr 22, 2016

Rollup of 6 pull requests #33154

Closed

bors added a commit that referenced this pull request May 8, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc

8e414e0

Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

bors merged commit 282afda into rust-lang:master May 8, 2016

sanxiyn deleted the unused-trait-import-3 branch May 8, 2016 14:01

jonas-schievink mentioned this pull request Jul 3, 2016

Unused imports lint should detect redundant prelude imports #28296

Closed

Warn unused trait imports, rebased #33091

Warn unused trait imports, rebased #33091

Conversation

sanxiyn commented Apr 19, 2016

rust-highfive commented Apr 19, 2016

bors commented Apr 19, 2016

nrc commented Apr 20, 2016

sanxiyn commented Apr 20, 2016

sanxiyn commented Apr 20, 2016

nrc commented Apr 20, 2016

bors commented Apr 20, 2016

bors commented Apr 21, 2016

bors commented Apr 21, 2016

alexcrichton commented Apr 21, 2016

bors commented Apr 22, 2016

bors commented Apr 22, 2016

alexcrichton commented Apr 22, 2016

mitaa commented Apr 23, 2016

sanxiyn commented Apr 23, 2016

sanxiyn commented Apr 23, 2016

sanxiyn commented Apr 25, 2016

bors commented Apr 25, 2016

bors commented Apr 25, 2016

bors commented Apr 25, 2016

bluss commented Apr 25, 2016

sanxiyn commented Apr 25, 2016

bors commented May 6, 2016

bors commented May 6, 2016

alexcrichton commented May 6, 2016

bors commented May 6, 2016

bors commented May 6, 2016

sanxiyn commented May 7, 2016

bors commented May 7, 2016

bors commented May 7, 2016

alexcrichton commented May 7, 2016

bors commented May 7, 2016

bors commented May 7, 2016

bors commented May 8, 2016

bors commented May 8, 2016

sanxiyn commented May 8, 2016

bors commented May 8, 2016

bors commented May 8, 2016