Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans: always register an item's symbol, even if duplicated. #32946

Merged
merged 1 commit into from
Apr 16, 2016
Merged

trans: always register an item's symbol, even if duplicated. #32946

merged 1 commit into from
Apr 16, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Apr 14, 2016

Fixes #32783 which was introduced by not always registering item symbols in #32742.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 14, 2016
@dotdash
Copy link
Contributor

dotdash commented Apr 14, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2016

📌 Commit cd85120 has been approved by dotdash

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit cd85120 with merge 0730d4a...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@eddyb
Copy link
Member Author

eddyb commented Apr 14, 2016

@bors retry

@Manishearth Manishearth mentioned this pull request Apr 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016
@Manishearth
Rollup merge of rust-lang#32946 - eddyb:issue-32783, r=dotdash
5bdbf8e 
trans: always register an item's symbol, even if duplicated.

Fixes rust-lang#32783 which was introduced by not always registering item symbols in rust-lang#32742.
bors added a commit that referenced this pull request Apr 15, 2016
@bors
Auto merge of #33005 - Manishearth:rollup, r=Manishearth
576229f 
Rollup of 11 pull requests

- Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997
- Failed merges:
@bors bors merged commit cd85120 into rust-lang:master Apr 16, 2016
@eddyb eddyb deleted the issue-32783 branch April 16, 2016 03:03
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 21, 2016
@alexcrichton alexcrichton mentioned this pull request May 4, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eddyb @rust-highfive @dotdash @bors @brson @nikomatsakis @pnkfelix