[breaking-batch] Add support for pub(restricted) syntax in the AST
#32688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jseyfried sorry to ping you on a random PR, but could you email me - my GH username at mozilla.com? I'd like to email you about name resolution plans. Thanks! |
|
@nrc No prob, just sent you an email. |
|
@bors r+ |
|
📌 Commit 432eb8a has been approved by |
bors
added a commit
that referenced
this pull request
Apr 6, 2016
[breaking-batch] Add support for `pub(restricted)` syntax in the AST This PR allows the AST to represent the `pub(restricted)` syntax from RFC 1422 (cc #32409). More specifically, it makes `ast::Visibility` non-`Copy` and adds two new variants, `Visibility::Crate` for `pub(crate)` and `Visitibility::Restricted { path: P<Path>, id: NodeId }` for `pub(path)`. plugin-[breaking-change] cc #31645 r? @pnkfelix
|
please wait before merging breaking-batch changes. Leave a note on #31645 or otherwise ping me if something needs merging. We have a couple of breaking changes pending as well as an issue which needs a breaking change to fix which I was waiting on. I'll try to bundle everything into the latest nightly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the AST to represent the
pub(restricted)syntax from RFC 1422 (cc #32409).More specifically, it makes
ast::Visibilitynon-Copyand adds two new variants,Visibility::Crateforpub(crate)andVisitibility::Restricted { path: P<Path>, id: NodeId }forpub(path).plugin-[breaking-change] cc #31645
r? @pnkfelix