Plumb obligations through librustc/infer #32596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| self.commit_if_ok(|_| { | ||
| let trace = TypeTrace::types(origin, a_is_expected, a, b); | ||
| self.equate(a_is_expected, trace, &a, &b).map(|_| ()) | ||
| self.equate(a_is_expected, trace, &a, &b) | ||
| .map(|InferOk { obligations, .. }| InferOk { value: (), obligations: obligations }) |
There was a problem hiding this comment.
Nit: seems worth it to add a helper for this; like |ok| ok.unit()
|
Looks great. r=me with nits addressed:
|
|
@bors r+ |
|
📌 Commit 86071ac has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 5, 2016
Plumb obligations through librustc/infer Like rust-lang#32542, but more like rust-lang#31867. TODO before merge: make an issue for the propagation of obligations through... uh, everywhere... then replace the `#????`s with the actual issue number. cc @jroesch r? @nikomatsakis
|
🎆 I feel like this PR has been a long time coming. Thanks for sticking with it @soltanmm. (OK, now onto the next step...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #32542, but more like #31867.
TODO before merge: make an issue for the propagation of obligations through... uh, everywhere... then replace the
#????s with the actual issue number.cc @jroesch
r? @nikomatsakis