libcore: update bytes/str reader to work with regions. #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@erickt -- If you can rebase this off a current incoming, I'll merge it today. Sorry, I tried merging it myself but git is behaving in a way I find puzzling. |
This optimizes away a copy.
|
@catamorphism: No problem, I rebased the commit onto HEAD. |
catamorphism
added a commit
that referenced
this pull request
Aug 24, 2012
libcore: update bytes/str reader to work with regions.
|
Merged, thanks! |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jan 4, 2024
Fix integer overflow ICEs from round_up_to_next_multiple_of Turns out the standard library _does_ have the function we need. So I swapped us to using the checked version in mmap/munmap where we can return an error, and we're still using the ICEy version in SIMD. I found one of the ICE cases by running this test: https://github.com/wbcchsyn/rust-mmap-allocator/blob/765bcaab6e3bfd1cb1e6eaac80ac7e821fb5979b/src/mmap_allocator.rs#L195-L210
jaisnan
pushed a commit
to jaisnan/rust-dev
that referenced
this pull request
Jul 29, 2024
Dependency upgrade resulting from `cargo update`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes away a copy, but it gets rid of
io::bytes_reader,io::bytes_reader_between, io::with_bytes_reader_between, andio::str_reader`. Slices and the with form supplant those old functions.