Make MSVC detection ludicrously robust #31158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
force-pushed
the
please-be-robust-already
branch
2 times, most recently
from
307d8f4
to
6fe9688
Compare
Should fix a few more edge cases Signed-off-by: Peter Atashian <[email protected]>
retep998
force-pushed
the
please-be-robust-already
branch
from
6fe9688
to
ff6e555
Compare
| "arm" => Some("x86_arm"), | ||
| _ => None, | ||
| fn bin_subdir(arch: &str) -> Vec<(&'static str, &'static str)> { | ||
| if let Some(host) = host_arch() { |
There was a problem hiding this comment.
Could you add some comments why this is necessary? It's not clear to me at least what the benefit is of not using cfg(target_arch)
There was a problem hiding this comment.
For example, if we're a 32-bit rustc on a 64-bit computer, we can take advantage of the amd64_x86 linker which has increased address space and performance so it can link very large projects with ease.
There was a problem hiding this comment.
Ah ok that sounds reasonable to me, yeah. Can you add some documentation to that effect?
|
Closing due to inactivity, but feel free to resubmit with comments addressed! |
|
VS 15 preview has come out so I intend to update this PR to support it. |
bors
added a commit
that referenced
this pull request
Jul 2, 2016
Make MSVC detection ludicrously robust Resurrection of #31158 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix a few more edge cases.
By using
Optionall the way down the rabbit hole this code can now fallback to older versions of MSVC if a newer version doesn't contain the necessary things.Also prefers the linker whose host matches the system's architecture instead of target_arch, but can also fallback from amd64 to x86 as the host.
cc #31151
r? @alexcrichton