Don't flush in BufWriter destructor after a panic in write #31068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,6 +300,7 @@ impl<R: Seek> Seek for BufReader<R> { | |||
| pub struct BufWriter<W: Write> { | |||
| inner: Option<W>, | |||
| buf: Vec<u8>, | |||
| panicked: bool, | |||
There was a problem hiding this comment.
Could you add a comment explaining what this flag is? e.g. explaining where it's set, what it's used to detect, and what goes wrong if it's not here.
|
Looks good to me, r=me with a comment, thanks! |
We don't want to write the same data twice. Closes rust-lang#30888
sfackler
force-pushed
the
bufwriter-panic
branch
from
676a55e
to
334bee3
Compare
|
@bors r=alexcrichton |
|
📌 Commit 334bee3 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 22, 2016
We don't want to write the same data twice. Closes #30888 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to write the same data twice.
Closes #30888
r? @alexcrichton