Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of the Entry API to the HashMap documentation. #31035

Merged
merged 1 commit into from
Jan 23, 2016

Conversation

nathankleyn
Copy link
Contributor

Responding to a thread of discussion on the Rust subreddit,
it was identified that the presence of the Entry API is not duly
publicised. This commit aims to add some reasonable examples of
common usages of this API to the main example section of the HashMap
documentation.

This is part of issue #29348.

Responding to [a thread of discussion on the Rust
subreddit](https://www.reddit.com/r/rust/comments/3racik/mutable_lifetimes_are_too_long_when_matching_an/),
it was identified that the presence of the Entry API is not duly
publicised. This commit aims to add some reasonable examples of
common usages of this API to the main example secion of the `HashMap`
documentation.

This is part of issue rust-lang#29348.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nathankleyn
Copy link
Contributor Author

r? @steveklabnik

@steveklabnik
Copy link
Member

Thank you! I agree that this should be advertised better, adding some examples here is a big improvement.

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 19, 2016

📌 Commit ccba72e has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2016
…ntry-api, r=steveklabnik

Responding to [a thread of discussion on the Rust subreddit](https://www.reddit.com/r/rust/comments/3racik/mutable_lifetimes_are_too_long_when_matching_an/),
it was identified that the presence of the Entry API is not duly
publicised. This commit aims to add some reasonable examples of
common usages of this API to the main example secion of the `HashMap`
documentation.

This is part of issue rust-lang#29348.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2016
…ntry-api, r=steveklabnik

Responding to [a thread of discussion on the Rust subreddit](https://www.reddit.com/r/rust/comments/3racik/mutable_lifetimes_are_too_long_when_matching_an/),
it was identified that the presence of the Entry API is not duly
publicised. This commit aims to add some reasonable examples of
common usages of this API to the main example secion of the `HashMap`
documentation.

This is part of issue rust-lang#29348.
bors added a commit that referenced this pull request Jan 23, 2016
@bors bors merged commit ccba72e into rust-lang:master Jan 23, 2016
@nathankleyn nathankleyn deleted the improve-visibility-of-entry-api branch January 24, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants