Rollup of 7 pull requests #31006
Rollup of 7 pull requests #31006
Conversation
The space between `T` and `Bound` is the typical style used in code and produced by rustdoc's rendering. Fixed first in Reflect's docs and then I fixed all occurrences in docs I could find.
I'm using clang 7.2 which works just fine to compile Rust with, but was disallowed.
|
@bors r+ p=10 |
|
📌 Commit a9c76a1 has been approved by |
|
⌛ Testing commit a9c76a1 with merge 6e57826... |
|
💔 Test failed - auto-mac-64-opt |
| for bit in 0..len { | ||
| tester.insert(Zst, ()); | ||
| } | ||
| assert_eq!(tester.len(), 1); |
There was a problem hiding this comment.
assertion here
thread '<main>' panicked at 'assertion failed: `(left == right)` (left: `0`, right: `1`)', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/test/run-pass/zero-sized-btreemap-insert.rs:40
@KiChjang I think the test is buggy, it should be length len right?
There was a problem hiding this comment.
It should really be an if-expression , if len is 0 then 0 else 1.
There was a problem hiding this comment.
Ok, I'm not sure what it would be, based on the peculiar PartialOrd impl. Shouldn't it be inserting each Zst as a new value?
There was a problem hiding this comment.
You didn't tell him about how you wrote PartialOrd.
There was a problem hiding this comment.
Sorry, you're right, I didn't get my bearings correct yet.
Original: rust-lang#30968 (My first PR was targeting the wrong branch)
Sorry for nitpicking, but I think the example of the expanded macro should be wrapped inside a pair of curly braces to match the macro definition. Also the current example triggers a variable redefinition error.
Fix spacing style of `T: Bound` in docs The space between `T` and `Bound` is the typical style used in code and produced by rustdoc's rendering. Fixed first in Reflect's docs and then I fixed all occurrences in docs I could find.
I'm using clang 7.2 which works just fine to compile Rust with, but was disallowed.
|
@bors r+ |
|
📌 Commit 652fa5c has been approved by |
T: Boundin docs #30988, Allow clang 7.x in configuration #30990, Makebtree_set::{IntoIter, Iter, Range}covariant #30998