Editing Chapter 1 #29538
Merged
Editing Chapter 1 #29538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of little details and things.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| Also note that the function body is wrapped in curly braces (`{` and `}`). Rust | ||
| requires these around all function bodies. It's considered good style to put | ||
| the opening curly brace on the same line as the function declaration, with one | ||
| line space in between. |
There was a problem hiding this comment.
Should this just be "space" instead of "line space"?
steveklabnik
force-pushed
the
ch1_edits
branch
from
7518fbf
to
2f4fbb2
Compare
Conceptually, this makes more sense as one introductory chapter.
|
Fixed up @apasel422 's comments, as well as fixing the build 😓 |
| | `x86_64-unknown-dragonfly` | ✓ | ✓ | | 64-bit DragonFlyBSD | | ||
| | `x86_64-rumprun-netbsd` | ✓ | | | 64-bit NetBSD Rump Kernel | | ||
| | `i686-pc-windows-msvc` (XP) | ✓ | | | Windows XP support | | ||
| | `x86_64-pc-windows-msvc` (XP) | ✓ | | | Windows XP support | |
There was a problem hiding this comment.
This list is sure to be insta-outdated in dead-tree format...
There was a problem hiding this comment.
Yeah, I am not entirely sure what to do about that, exactly.
|
r=me |
|
@bors: r=brson rollup |
|
📌 Commit 7bb193c has been approved by |
|
Thanks @brson! I didn't leave a comment for every change, but I should have addressed it all. |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 5, 2015
I did some preliminary editing work with No Starch on the first chapter of the book, and here's some of the results. We're going to want to return to this later when @brson etc's new rustup work is done, so this is mostly just a first pass. But, we agreed that having separate chapters for each of this bit of intro is a bit excessive. So let's move all of this intro stuff into one chapter. I'd appreciate a careful review of this, as there was also some confusion about some things, which resulted in me taking one huge markdown file apart and splitting it back up, as well as some editor issues, so I _think_ this looks good, but double checking things matters! /cc @aturon
bors
added a commit
that referenced
this pull request
Nov 5, 2015
ollie27
added a commit
to ollie27/rust
that referenced
this pull request
Jan 25, 2016
It was moved in rust-lang#29538.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some preliminary editing work with No Starch on the first chapter of the book, and here's some of the results. We're going to want to return to this later when @brson etc's new rustup work is done, so this is mostly just a first pass.
But, we agreed that having separate chapters for each of this bit of intro is a bit excessive. So let's move all of this intro stuff into one chapter.
I'd appreciate a careful review of this, as there was also some confusion about some things, which resulted in me taking one huge markdown file apart and splitting it back up, as well as some editor issues, so I think this looks good, but double checking things matters!
/cc @aturon