Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2015

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@killercup
Copy link
Contributor

Thanks! Remember to close #29234 after this is merged. 😄 (Or add Fix #29234 to your commit message.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ignored, so that it doesn't fail

@steveklabnik
Copy link
Contributor

This looks good! Yes, if you could fix that failure by marking that first block as ignore, and while you're at it, fix up that commit message, r=me after :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Another issue. So, you actually need something after a documentation comment for this to parse, so add something like

# fn foo() { }

Does that make sense? That's why the build is failing. I think there's an example in this file...

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

📌 Commit dda7a3c has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

@EFindlay sorry about that! you have to actually leave a comment when you push, github won't send a notification :/

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 10, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 10, 2015
bors added a commit that referenced this pull request Nov 10, 2015
@bors bors merged commit dda7a3c into rust-lang:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants