Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a run-pass test for #28189 #29281

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Add a run-pass test for #28189 #29281

merged 1 commit into from
Oct 25, 2015

Conversation

skeleten
Copy link
Contributor

Closes #28189

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@skeleten
Copy link
Contributor Author

r? steveklabnik

@apasel422
Copy link
Contributor

@skeleten FYI, you can add Closes #28189 to either the PR message or commit message to have the corresponding issue closed once this PR is merged.

@skeleten
Copy link
Contributor Author

Thanks for that hint, I wasn't quite sure if this should close the issue, but I'll guess I'll add it :)

@steveklabnik
Copy link
Member

@bors: r+

Thank you!

@bors
Copy link
Contributor

bors commented Oct 24, 2015

📌 Commit 3790406 has been approved by steveklabnik

bors added a commit that referenced this pull request Oct 25, 2015
@bors
Copy link
Contributor

bors commented Oct 25, 2015

⌛ Testing commit 3790406 with merge 079f384...

@bors bors merged commit 3790406 into rust-lang:master Oct 25, 2015
@skeleten skeleten deleted the issue-28189 branch October 25, 2015 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants