Remove reference to hello_world.rs in TRPL §2.2
#29193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 21, 2015
…ichton When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section. r? @steveklabnik (Let me know if I'm sending too many PRs -- I can batch up TRPL edits, say, per chapter, if that works better. Or I can just refrain from editing TRPL as I read through it, if these are not sufficiently useful.)
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 22, 2015
…ichton When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section. r? @steveklabnik (Let me know if I'm sending too many PRs -- I can batch up TRPL edits, say, per chapter, if that works better. Or I can just refrain from editing TRPL as I read through it, if these are not sufficiently useful.)
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 22, 2015
…ichton When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section. r? @steveklabnik (Let me know if I'm sending too many PRs -- I can batch up TRPL edits, say, per chapter, if that works better. Or I can just refrain from editing TRPL as I read through it, if these are not sufficiently useful.)
bors
added a commit
that referenced
this pull request
Oct 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading this paragraph, the beginning Rust programmer is starting
to write a Hello World program. We have just told her to name the file
main.rs, and immediately afterward, ahello_world.rsis mentioned.I changed this to an unrelated filename (incidentally one that appears
in this repository) to make it clear that this is just an example.
Also, wording it as a declarative sentence rather than an imperative one
further separates it from the Hello World instructions in this section.
r? @steveklabnik
(Let me know if I'm sending too many PRs -- I can batch up TRPL edits, say, per chapter, if that works better. Or I can just refrain from editing TRPL as I read through it, if these are not sufficiently useful.)