rustfmt librand #29117
rustfmt librand #29117
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| self.mem[i + 4] = e; | ||
| self.mem[i + 5] = f; | ||
| self.mem[i + 6] = g; | ||
| self.mem[i + 7] = h; |
There was a problem hiding this comment.
Lines 105-108 in the macro have not been touched, however the same block here has been reformatted. The same happened at line 370. Is this the expected behavior?
There was a problem hiding this comment.
Rustfmt can't format macro definitions yet: https://github.com/nrc/rustfmt/issues/8
There was a problem hiding this comment.
Should the macro stay in its compact form then, or is it better if it's re-formatted as the rest of the code?
There was a problem hiding this comment.
It's to good to be consistent, I think. I'd reformat the macro too, yea.
|
@bors: r+ |
|
📌 Commit 8a0b9c0 has been approved by |
|
@bors: retry force |
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-msvc-64-opt... |
r? @nrc
Re-submission of the closed PR #29054 with the additional rustfmt-zation of the full librand.