Skip to content

doc: Mention split_whitespace in split doc#28868

Merged
bors merged 1 commit into
rust-lang:masterfrom
JIghtuse:str_doc
Oct 7, 2015
Merged

doc: Mention split_whitespace in split doc#28868
bors merged 1 commit into
rust-lang:masterfrom
JIghtuse:str_doc

Conversation

@JIghtuse

@JIghtuse JIghtuse commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 3120bfe1088346bce1512300b343782d02c9ea9a

Thanks!

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r-

@steveklabnik

Copy link
Copy Markdown
Contributor

@JIghtuse would you mind writing a link to link this method to the definition, so users don't have to search for it?

///
/// Use [`.split_whitespace()`][split_whitespace] for this behavior.
///
/// [split_whitespace]: #method.split_whitespace

would follow the idiom.

Thanks! r=me after, @alexcrichton or anyone else

@JIghtuse

JIghtuse commented Oct 6, 2015

Copy link
Copy Markdown
Contributor Author

@steveklabnik sure. I just didn't know how to do that.

@JIghtuse

JIghtuse commented Oct 6, 2015

Copy link
Copy Markdown
Contributor Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned aturon Oct 6, 2015
@steveklabnik

Copy link
Copy Markdown
Contributor

No worries! Thanks so much. 👍

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Oct 6, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 836be40 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 7, 2015
bors added a commit that referenced this pull request Oct 7, 2015
@bors

bors commented Oct 7, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 836be40 with merge c056cbb...

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@bors bors merged commit 836be40 into rust-lang:master Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants