Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't display duplicate trait errors #28645

Merged
merged 2 commits into from
Sep 28, 2015
Merged

don't display duplicate trait errors #28645

merged 2 commits into from
Sep 28, 2015

Commits on Sep 26, 2015

  1. deduplicate trait errors before they are displayed 

    Because of type inference, duplicate obligations exist and cause duplicate
errors. To avoid this, only display the first error for each (predicate,span).

The inclusion of the span is somewhat bikesheddy, but *is* the more
conservative option (it does not remove some instability, as duplicate
obligations are ignored by `duplicate_set` under some inference conditions).

Fixes rust-lang#28098
cc rust-lang#21528 (is it a dupe?)
    @arielb1
    Ariel Ben-Yehuda authored and arielb1 committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    fe6ad09 View commit details
    Browse the repository at this point in the history

  2. show each object-safety violation once 

    different supertraits can suffer from the same object-safety violation,
leading to duplication in the error message. Avoid it.

Fixes rust-lang#20692
    @arielb1
    Ariel Ben-Yehuda authored and arielb1 committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    346088b View commit details
    Browse the repository at this point in the history