-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require issue annotations for #[unstable] features #27818
Conversation
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
This is broken into separate commits per library, and the massive removal count is because this is rebased on #27684 so I didn't have to tag any of those unstable items. |
(Travis failed due to a missing issue on an item, but I guess that's somewhat expected.) |
d2465d7
to
644d6c7
Compare
☔ The latest upstream changes (presumably #27684) made this pull request unmergeable. Please resolve the merge conflicts. |
644d6c7
to
6011882
Compare
☔ The latest upstream changes (presumably #27696) made this pull request unmergeable. Please resolve the merge conflicts. |
6011882
to
1539f1b
Compare
Sorry for the reviewing delay. LGTM! @bors: r+ |
📌 Commit 1539f1b has been approved by |
⌛ Testing commit 1539f1b with merge 6b5e0e7... |
💔 Test failed - auto-win-msvc-64-opt |
|
1539f1b
to
5101876
Compare
@bors: r=aturon 5101876 |
⌛ Testing commit 5101876 with merge df572f0... |
💔 Test failed - auto-mac-32-opt |
5101876
to
ed37f05
Compare
@bors: r=aturon ed37f05 |
⌛ Testing commit ed37f05 with merge 80905c4... |
💔 Test failed - auto-mac-32-opt |
new failure
|
This turns an `#[unstable]` tag without an `issue` annotation into a hard error to ensure that we've always got a tracking issue for unstable features in the standard library.
ed37f05
to
8ef1e3b
Compare
This commit turns `#[unstable]` attributes missing an `issue` annotation into a hard error. This will require the libs team to ensure that there's a tracking issue for all unstable features in the standard library. All existing unstable features have had issues created and they've all been updated. Yay! Closes #26868
This commit turns
#[unstable]
attributes missing anissue
annotation into a hard error. This will require the libs team to ensure that there's a tracking issue for all unstable features in the standard library.All existing unstable features have had issues created and they've all been updated. Yay!
Closes #26868