Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require issue annotations for #[unstable] features #27818

Merged
merged 9 commits into from
Aug 16, 2015

Conversation

alexcrichton
Copy link
Member

This commit turns #[unstable] attributes missing an issue annotation into a hard error. This will require the libs team to ensure that there's a tracking issue for all unstable features in the standard library.

All existing unstable features have had issues created and they've all been updated. Yay!

Closes #26868

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @rust-lang/libs, @huonw

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pcwalton Aug 13, 2015
@alexcrichton
Copy link
Member Author

This is broken into separate commits per library, and the massive removal count is because this is rebased on #27684 so I didn't have to tag any of those unstable items.

@huonw
Copy link
Member

huonw commented Aug 13, 2015

(Travis failed due to a missing issue on an item, but I guess that's somewhat expected.)

@bors
Copy link
Contributor

bors commented Aug 14, 2015

☔ The latest upstream changes (presumably #27684) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Aug 14, 2015

☔ The latest upstream changes (presumably #27696) made this pull request unmergeable. Please resolve the merge conflicts.

@aturon
Copy link
Member

aturon commented Aug 14, 2015

Sorry for the reviewing delay. LGTM!

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 14, 2015

📌 Commit 1539f1b has been approved by aturon

@bors
Copy link
Contributor

bors commented Aug 14, 2015

⌛ Testing commit 1539f1b with merge 6b5e0e7...

@bors
Copy link
Contributor

bors commented Aug 14, 2015

💔 Test failed - auto-win-msvc-64-opt

@Gankra
Copy link
Contributor

Gankra commented Aug 14, 2015


../src/libstd\sys/windows\ext\fs.rs:24:1: 49:2 error: non-deprecated unstable items need to point to an issue with `issue = "NNN"`
../src/libstd\sys/windows\ext\fs.rs:24 pub trait OpenOptionsExt {
../src/libstd\sys/windows\ext\fs.rs:25     /// Overrides the `dwDesiredAccess` argument to the call to `CreateFile`
../src/libstd\sys/windows\ext\fs.rs:26     /// with the specified value.
../src/libstd\sys/windows\ext\fs.rs:27     fn desired_access(&mut self, access: u32) -> &mut Self;
../src/libstd\sys/windows\ext\fs.rs:28 
../src/libstd\sys/windows\ext\fs.rs:29     /// Overrides the `dwCreationDisposition` argument to the call to
                                       ...

@alexcrichton
Copy link
Member Author

@bors: r=aturon 5101876

@bors
Copy link
Contributor

bors commented Aug 15, 2015

⌛ Testing commit 5101876 with merge df572f0...

@bors
Copy link
Contributor

bors commented Aug 15, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon ed37f05

@bors
Copy link
Contributor

bors commented Aug 15, 2015

⌛ Testing commit ed37f05 with merge 80905c4...

@bors
Copy link
Contributor

bors commented Aug 15, 2015

💔 Test failed - auto-mac-32-opt

@bluss
Copy link
Member

bluss commented Aug 15, 2015

new failure

maketest: alloc-extern-crates
maketest: allow-non-lint-warnings-cmdline
maketest: allow-warnings-cmdline-stability
----- /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/test/run-make/allow-warnings-cmdline-stability/ --------------------
------ stdout ---------------------------------------------
DYLD_LIBRARY_PATH="/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/obj/i686-apple-darwin/test/run-make/allow-warnings-cmdline-stability:/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/obj/i686-apple-darwin/stage2/lib:" /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/obj/i686-apple-darwin/stage2/bin/rustc --out-dir /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/obj/i686-apple-darwin/test/run-make/allow-warnings-cmdline-stability -L /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/obj/i686-apple-darwin/test/run-make/allow-warnings-cmdline-stability bar.rs

------ stderr ---------------------------------------------
bar.rs:11:1: 16:16 error: non-deprecated unstable items need to point to an issue with `issue = "NNN"`
bar.rs:11 #![crate_type = "lib"]
bar.rs:12 #![feature(staged_api)]
bar.rs:13 #![staged_api]
bar.rs:14 #![unstable(feature = "test_feature")]
bar.rs:15 
bar.rs:16 pub fn baz() { }
error: aborting due to previous error
make[1]: *** [bar] Error 101

------        ---------------------------------------------

@alexcrichton
Copy link
Member Author

@bors: r=aturon 8ef1e3b

bors added a commit that referenced this pull request Aug 16, 2015
This commit turns `#[unstable]` attributes missing an `issue` annotation into a hard error. This will require the libs team to ensure that there's a tracking issue for all unstable features in the standard library.

All existing unstable features have had issues created and they've all been updated. Yay!

Closes #26868
@bors
Copy link
Contributor

bors commented Aug 16, 2015

⌛ Testing commit 8ef1e3b with merge 9165a4e...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants