Remove transmute from btree::node::Node::as_slices_internal_mut#27624
Merged
Conversation
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
r? @gankro |
apasel422
changed the title
btreelibcollections
Member
There was a problem hiding this comment.
I think this might be losing aliasing information in LLVM.
Member
|
cc #27252, there's a bit of duplication between these two |
Collaborator
|
☔ The latest upstream changes (presumably #27252) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Rebased. |
apasel422
changed the title
libcollectionsbtree::node::Node::as_slices_internal_mut
Contributor
Author
|
Does this need any further changes? |
Contributor
|
Oh whoops, I thought this has been accepted. @bors r+ |
Collaborator
|
📌 Commit 28d5d2f has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 18, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27620.