Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associated defaults - for 1.2.0 #27364

Closed
wants to merge 3 commits into from
Closed

Associated defaults - for 1.2.0 #27364

wants to merge 3 commits into from

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jul 28, 2015

r? @brson

Ariel Ben-Yehuda and others added 3 commits July 29, 2015 00:55
@arielb1
Clean-up check_impl_items_against_trait
4bb0626
@arielb1
require reimplementations of all items when a defaulted associated ty…
2e5ce37 
…pe is overriden

This is a
[breaking-change]
but it follows the RFC (not sure whether it will be accepted).
@arielb1
make not reimplementing defaults while overriding an associated type …
426139c 
…only a warning
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@brson
Copy link
Contributor

brson commented Jul 28, 2015

Waiting for #26728 to be accepted.

@arielb1 arielb1 mentioned this pull request Jul 29, 2015
Closed
@brson brson added relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 29, 2015
@brson
Copy link
Contributor

brson commented Jul 29, 2015

Per this comment there are still problems with default assoc types and they are going to be feature gated.

@brson brson closed this Jul 29, 2015
@brson brson mentioned this pull request Jul 29, 2015
Merged
brson added a commit to brson/rust that referenced this pull request Jul 29, 2015
@brson
Feature gate associated type defaults
a09bce1 
There are multiple issues with them as designed and implemented.

cc rust-lang#27364
brson added a commit to brson/rust that referenced this pull request Jul 29, 2015
@brson
Feature gate associated type defaults
6e6d5b1 
There are multiple issues with them as designed and implemented.

cc rust-lang#27364

Conflicts:
	src/libsyntax/feature_gate.rs
	src/test/auxiliary/xcrate_associated_type_defaults.rs
bors added a commit that referenced this pull request Jul 31, 2015
@bors
Auto merge of #27382 - brson:gate-assoc-type, r=alexcrichton
8d2eb59 
There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis 

cc #27364

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arielb1 @rust-highfive @brson