Even moar editing #24273
Even moar editing #24273
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
src/doc/trpl/functions.md
Outdated
There was a problem hiding this comment.
s/expression based/expression-based/
steveklabnik
force-pushed
the
even_moar_editing
branch
from
45fa450 to
2cc24a7
Compare
|
Thanks @apasel422 ! updated |
There was a problem hiding this comment.
Out of curiosity, why the switch to a unicode apostrophe? I'm not sure that other contributors to the docs may follow that style if it's harder to type, but I dunno if it makes much of an inconsistency.
There was a problem hiding this comment.
it's technically more correct and a very commonly requested thing, I know @dherman really wanted it 😄
There was a problem hiding this comment.
I guess I'm just worried that we'll have to continually make passes through the documentation to update something like this, or I just don't know how to type it!
There was a problem hiding this comment.
I don't plan on doing a mega-edit to update them, it's only because I'm already doing a readthrough of all this that I'm fixing it.
There was a problem hiding this comment.
I would suggest using smartypants, which was designed to do this sort of thing, rather than using untypeable(?) characters in the markdown, especially for common punctuation. The version of hoedown rustdoc uses supports it, so it'd be a matter of adding an extra pass to rustdoc for the book.
There was a problem hiding this comment.
I really miss typographic quotes as well, but I think we ought to be consistent. We should run smartypants at build-time. Hoedown ships with a smartypants binary which we ought to add to the existing rust wrapper.
There was a problem hiding this comment.
maybe prefer ASCII is always nice.
steveklabnik
force-pushed
the
even_moar_editing
branch
from
2cc24a7 to
8b6987a
Compare
Three more sections
9 participants
Three more sections