Remove incorrect example from docs #24167
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Hey @hauleth ! We're not generally purging everything that doesn't work on beta, but you're right in that this functionality is gone, and isn't coming back any time soon. So 👍 to removing it. Thank you! |
|
@bors: r+ rollup |
|
📌 Commit 4cf5930 has been approved by |
|
@steveklabnik yeah, I know, but this one IMHO still should be purged and (when possible) replaced with example that is not using |
|
@hauleth yeah, just making sure that you know it's not a universal policy :) |
|
@bors: r+ rollup |
|
📌 Commit 4695bf0 has been approved by |
…om-mpsc, r=steveklabnik As beta is now released and is "suggested" version of `rustc` then there should be no code (in documentation) that will not compile with it. This one does not. So according to [this great talk](http://delete-your-code.herokuapp.com/), I am doing what should be done.
As beta is now released and is "suggested" version of
rustcthen there should be no code (in documentation) that will not compile with final (stable) API. This one does not (I'm really counting days tillold_ioandold_pathwill be removed for good).So according to this great talk, I am doing what should be done.