Skip to content

Resolve type vars when inferring borrow kinds for upvars#21561

Merged
bors merged 1 commit intorust-lang:masterfrom
edwardw:deref
Jan 25, 2015
Merged

Resolve type vars when inferring borrow kinds for upvars#21561
bors merged 1 commit intorust-lang:masterfrom
edwardw:deref

Conversation

@edwardw
Copy link
Contributor

@edwardw edwardw commented Jan 23, 2015

As part of #20432, upvar checking is now moved out of regionck to its
own pass and before regionck. But regionck has some type resolution of
its own. Without them, now separated upvar checking may be tripped over
by residue ty_infer.

Closes #21306

As part of rust-lang#20432, upvar checking is now moved out of regionck to its
own pass and before regionck. But regionck has some type resolution of
its own. Without them, now separated upvar checking may be tripped over
by residue `ty_infer`.

Closes rust-lang#21306
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors r=nikomatsakis 296777e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, yay for cleanup.

bors added a commit that referenced this pull request Jan 25, 2015
As part of #20432, upvar checking is now moved out of regionck to its
own pass and before regionck. But regionck has some type resolution of
its own. Without them, now separated upvar checking may be tripped over
by residue `ty_infer`.

Closes #21306
@bors
Copy link
Collaborator

bors commented Jan 25, 2015

⌛ Testing commit 296777e with merge 458a6a2...

@bors
Copy link
Collaborator

bors commented Jan 25, 2015

@bors bors merged commit 296777e into rust-lang:master Jan 25, 2015
@edwardw edwardw deleted the deref branch January 26, 2015 05:19
lnicola pushed a commit to lnicola/rust that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: autoderef failed

5 participants