Skip to content

Conversation

@loganchien
Copy link
Contributor

Slightly change the title to make it look more consistent with other chapters (e.g. Match.)

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Contributor

Actually, it should be the other way around. Care to fix match instead?

@steveklabnik
Copy link
Contributor

(and thank you!)

@loganchien
Copy link
Contributor Author

However, unfortunately, it seems that the backticks do not work in the title block of pandoc. Unlike the backticks in the headings, the backticks in the title block will be left as-is (and won't be changed to the <code></code> tags.) Is this the preferred result?

@steveklabnik
Copy link
Contributor

Ugh. No. :(

I guess this patch works, then. Thank you!

@steveklabnik
Copy link
Contributor

@bors: r+ 8c3d914

@aturon
Copy link
Contributor

aturon commented Jan 21, 2015

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 21, 2015
Slightly change the title to make it look more consistent with other chapters (e.g. Match.)
@bors bors merged commit 8c3d914 into rust-lang:master Jan 22, 2015
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Jan 5, 2026
…nlay-hint-location-links

feat: Add location links for generic parameter type hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants