mk: Disable extra debugging on the non-dev release channels. #20713 #20715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#20713 This makes std not do overflow checks for releases.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Seems reasonable, as long as we do integration tests with debugging on. |
|
cc #17665, moving to optimize-by-default would also be another strategy here. |
|
Closing this until there's more traction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes std not do overflow checks for releases.
This was an easy patch to make, so just submitting for discussion.