Skip to content

Conversation

@brson
Copy link
Contributor

@brson brson commented Jan 6, 2015

A whole lot happened this cycle. I tried to highlight the best stuff. Please review and note important stuff I'm missing or foolish mistakes.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson changed the title Relnotes 1.0.0-alpha release notes Jan 6, 2015
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to mention trait object safety here as well.

@jroesch
Copy link
Contributor

jroesch commented Jan 6, 2015

It might be interesting to reference progress on experimental/feature-gated parts of the language for those who don't follow the GitHub and IRC chatter closely. For example a ton of work was done on associated types since 0.12.0 and without closely following the community I would have no idea that they are much much more stable then they were and ready to be experimented with and hammered on.

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to fallback RFC doesn't parse as intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be [fallback][fallback] so the (either i32 or f64) part isn't parsed as the link's URL.

@brson
Copy link
Contributor Author

brson commented Jan 6, 2015

Current feedback has been addressed.

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "will not" this be softened slightly? It seems to me we still want some room for tweaks and adjustments based on feedback.

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be Sync and Send?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

brson and others added 2 commits January 6, 2015 22:15
bors added a commit that referenced this pull request Jan 7, 2015
A whole lot happened this cycle. I tried to highlight the best stuff. Please review and note important stuff I'm missing or foolish mistakes.
@bors bors merged commit 9d8de1f into rust-lang:master Jan 7, 2015
lnicola added a commit to lnicola/rust that referenced this pull request Sep 18, 2025
fix: add `else` keyword completion after `let` statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.