Make the improper_ctypes lint more robust #20311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
tomjakubowski
force-pushed
the
improper-ctypes-fixes
branch
from
600ca26 to
25f6d53
Compare
It now checks extern fns in addition to foreign fns and checks `DefStruct` defs as well. There is room for improvement: for example, I believe that pointers should be safe in extern fn signatures regardless of the pointee's representation. The `FIXME` on `rust_begin_unwind_fmt` is because I don't think it should be, or needs to be, C ABI (cc @eddyb) and it takes a problematic `fmt::Arguments` structure by value. Fix rust-lang#20098, fix rust-lang#19834
tomjakubowski
force-pushed
the
improper-ctypes-fixes
branch
from
25f6d53 to
5ec3ee9
Compare
|
I think the issue with |
|
Yes I think it's fine to remove the FIXME but leave the |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now checks extern fns in addition to foreign fns and checks
DefStructdefs as well.
There is room for improvement: for example, I believe that pointers
should be safe in extern fn signatures regardless of the pointee's
representation.
The
FIXMEonrust_begin_unwind_fmtis because I don't think itshould be, or needs to be, C ABI (cc @eddyb) and it takes a problematic
fmt::Argumentsstructure by value.Fix #20098, fix #19834