rustdoc: Add tooltips to sidebar (v3) #20221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Re-assigning to @alexcrichton since he was cited in the text (or @steveklabnik ) |
|
Needs a rebase |
liigo
force-pushed
the
rustdoc-sidebar-tooltips-v3
branch
2 times, most recently
from
1ee163c to
e788b09
Compare
|
rebased |
| '"' => result.push_str("""), | ||
| '\'' => result.push_str("'"), | ||
| _ => result.push(c), | ||
| } |
There was a problem hiding this comment.
Could this use rustdoc::html::escape instead of duplicating logic?
liigo
force-pushed
the
rustdoc-sidebar-tooltips-v3
branch
from
e788b09 to
d22f03a
Compare
liigo
force-pushed
the
rustdoc-sidebar-tooltips-v3
branch
from
d22f03a to
2b11a80
Compare
|
@alexcrichton I've addressed all your review comments in latest commit, and rebased. Sorry for the delay. |
|
⌛ Testing commit 2b11a80 with merge 9a0042b... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit 2b11a80 with merge 65cc262... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit 2b11a80 with merge cb5b1f1... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 23, 2015
This pull request add tooltips to most links of sidebar. The tooltips display "summary line" of items' document. Some lengthy/annoying raw markdown code are eliminated, such as links and headers. - `[Rust](http://rust-lang.org)` displays as `Rust` (no URLs) - `# header` displays as `header` (no `#`s) Some inline spans, e.g. ``` `code` ``` and ```*emphasis*```, are kept as they are, for better readable. I've make sure `&` `'` `"` `<` and `>` are properly displayed in tooltips, for example, `&'a Option<T>`. Online preview: http://liigo.com/tmp/tooltips/std/index.html @alexcrichton @steveklabnik since you have reviewed my previous ([v1](https://github.com/rust-lang/rust/pull/13014),[v2](https://github.com/rust-lang/rust/pull/16448)) PRs of this serise, which have been closed for technical reasons. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add tooltips to most links of sidebar.
The tooltips display "summary line" of items' document.
Some lengthy/annoying raw markdown code are eliminated, such as links and headers.
[Rust](http://rust-lang.org)displays asRust(no URLs)# headerdisplays asheader(no#s)Some inline spans, e.g.
codeand*emphasis*, are kept as they are, for better readable.I've make sure
&'"<and>are properly displayed in tooltips, for example,&'a Option<T>.Online preview: http://liigo.com/tmp/tooltips/std/index.html
@alexcrichton @steveklabnik since you have reviewed my previous (v1,v2) PRs of this serise, which have been closed for technical reasons. Thank you.