-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make single-variant "c-like" enums have no size. #20122
Conversation
This makes an enum like `enum Foo { Foo }` be zero-sized. If a discriminant is set to non-zero, it still treats it as a c-like enum. Fixes rust-lang#15747
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
r=me with test. |
34d86f0
to
98ae8ad
Compare
@luqmana added, despite knowing it will conflict another one of my pull requests >.> |
I think this has a failure in the debuginfo tests:
|
Closing due to inactivity, but feel free to reopen with a rebase! |
This makes an enum like
enum Foo { Foo }
be zero-sized. If adiscriminant is set to non-zero, it still treats it as a c-like enum.
Fixes #15747