Revamped testing guide #19627
Revamped testing guide #19627
Conversation
src/doc/guide-testing.md
Outdated
There was a problem hiding this comment.
The glob crate is unrelated to use foo:::*. All you need for that is #![feature(globs)] in the crate root.
|
cc #19560 - don't want to lose the doc change if that PR merges first. |
There was a problem hiding this comment.
This was copied straight from the previous version of the text. Regardless, idempotent is the correct word here: you don't want multiple calls to the test to have different outcomes.
There was a problem hiding this comment.
Oh! I didn't realize it was a word.
There was a problem hiding this comment.
One of my favorites! http://en.wikipedia.org/wiki/Idempotence
There was a problem hiding this comment.
Yeah. I saw that once I saw it was real. Good to know.
steveklabnik
force-pushed
the
testing_guide
branch
2 times, most recently
from
70ef7aa to
5d8ff6a
Compare
|
@sfackler addressed your comments and included the fixes from your PR. |
src/doc/guide-testing.md
Outdated
There was a problem hiding this comment.
Missing an "is" from this line.
What we will not be talking about is the ...
steveklabnik
force-pushed
the
testing_guide
branch
2 times, most recently
from
2bc2574 to
5b11154
Compare
steveklabnik
force-pushed
the
testing_guide
branch
from
5b11154 to
d4ea71d
Compare
There was a problem hiding this comment.
FWIW, it's a little sad to lose the headings, since it's useful to link people directly to this optimisation section when they encounter a optimised-out benchmark.
There was a problem hiding this comment.
@huonw mind opening up a new issue with these comments? this already got merged, and I'm not going to get to them tonight, and I don't want to lose them :)
6 participants
No description provided.