Implement BitOps for TreeSet #19561
Merged
Implement BitOps for TreeSet #19561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_eq!(v, vec![11, 22, 33, 40, 42]); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
Is there any reason you went for slightly more complex tests than you used for TrieSet?
There was a problem hiding this comment.
No particularly strong reason, I actually just pulled these numbers straight from the tests for union/intersection/{symmetric} difference for TreeSet since they were easily accessible/in the same file. Would you like me to dial them back a little?
csouth3
force-pushed
the
treeset-bitops
branch
from
52b4b76
to
da50db0
Compare
|
@gankro Here is the |
bors
added a commit
that referenced
this pull request
Dec 8, 2014
Implement the `BitOr`, `BitAnd`, `BitXor`, and `Sub` traits from `std::ops` for TreeSet. The behavior of these operator overloads is consistent with [RFC 235](https://github.com/rust-lang/rfcs/blob/master/text/0235-collections-conventions.md#combinations). r? @gankro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
BitOr,BitAnd,BitXor, andSubtraits fromstd::opsfor TreeSet. The behavior of these operator overloads is consistent with RFC 235.r? @gankro