rustdoc: Support associated types #19174
Conversation
|
Some rendered docs are here: http://homer.crystae.net/doc/foo/ |
|
The render output looks good to me. AFAICT it contains all the necessary information:
|
|
One thing I'll note is that I couldn't test docs for cross-crate associated types because of an ICE (#18048). I know for a fact that bounds on re-exported associated types will be wrong/missing but there could be other issues too. |
| @@ -2225,7 +2249,17 @@ impl Clean<Item> for ty::AssociatedType { | |||
| source: DUMMY_SP.clean(cx), | |||
| name: Some(self.name.clean(cx)), | |||
| attrs: Vec::new(), | |||
| inner: AssociatedTypeItem, | |||
| // FIXME: this is wrong, but cross-crate associated types are broken | |||
| // anyway, for the time being. | |||
There was a problem hiding this comment.
Could you reference #18048 here as well?
|
@tomjakubowski my hero! just one tiny nit, and otherwise r=me, fantastic work! |
tomjakubowski
force-pushed
the
rustdoc-assoc-types
branch
from
ce93017
to
8775c21
Compare
|
@alexcrichton addressed the nit |
tomjakubowski
force-pushed
the
rustdoc-assoc-types
branch
from
8775c21
to
508e02c
Compare
|
@tomjakubowski I discovered during the recent rollup that this causes rustdoc to fail when generating documentation for the repo, you can see the fix I had at the end of the rollup: alexcrichton@c4fa21d |
|
Whoops! Sorry about that. I could swear I'd done a |
tomjakubowski
force-pushed
the
rustdoc-assoc-types
branch
from
508e02c
to
f0cbe5f
Compare
|
@alexcrichton re-r? I took a slightly different tack and matched on the missing variant while keeping the panic for the |
|
r+, but needs a rebase |
tomjakubowski
force-pushed
the
rustdoc-assoc-types
branch
from
f0cbe5f
to
de94f0a
Compare
|
rebased |
…crichton Render associated types on traits and impls, and qualified paths in types. r? @alexcrichton
Render associated types on traits and impls, and qualified paths in types.
r? @alexcrichton