collections: impl Deref for Vec/String #18443
Conversation
|
|
| @@ -58,7 +58,7 @@ impl<'a,T> IntoMaybeOwnedVector<'a,T> for &'a [T] { | |||
| impl<'a,T> MaybeOwnedVector<'a,T> { | |||
| pub fn iter(&'a self) -> slice::Items<'a,T> { | |||
| match self { | |||
| &Growable(ref v) => v.iter(), | |||
| &Growable(ref v) => v.as_slice().iter(), | |||
There was a problem hiding this comment.
Note that this was require to avoid an obscure ICE somewhere in rustc. I wasn't able to quite track it down just yet, but I figured that the benefit of landing these trait impls would be much greater!
There was a problem hiding this comment.
Worth adding a FIXME or issue?
There was a problem hiding this comment.
What kind of ICE? I have a nasty one in a much larger changeset, and this could be helpful.
There was a problem hiding this comment.
Ah sorry I don't have the precise one offhand, but talking with @nikomatsakis it sounded like he was running into a very similar ICE (in this crate even!) and was fixing it, so I think this may fix itself soon.
The ICE was in ty::type_contents with a lookup in a map failing, and the context was somewhere in the bowels of trans (the immediate caller was expr_use_visitor::consume_expr. With the fix probably coming soon though I may just leave this for now.
There was a problem hiding this comment.
Ah yes, it looked precisely like that, thanks @jakub-!
|
:D |
This commit adds the following impls:
impl<T> Deref<[T]> for Vec<T>
impl<T> DerefMut<[T]> for Vec<T>
impl Deref<str> for String
This commit also removes all duplicated inherent methods from vectors and
strings as implementations will now silently call through to the slice
implementation. Some breakage occurred at std and beneath due to inherent
methods removed in favor of those in the slice traits and std doesn't use its
own prelude,
cc rust-lang#18424
alexcrichton
force-pushed
the
deref-vec-and-string
branch
from
2061e26 to
8e9f8f9
Compare
|
\o/ |
|
@alexcrichton It's possible to use |
|
It should be, yes! I believe we're recommending |
I don't know the full story of feature gates, 1.0 and the stability channels, but it just occurred to me that people could end up using |
|
I actually strongly prefer |
|
Coming from python, |
|
From Python I might expect string[] to behave like string[:], which would make a sort of copy. On Thu, Oct 30, 2014 at 10:30 AM, Sean McArthur [email protected]
|
This commit adds the following impls:
This commit also removes all duplicated inherent methods from vectors and
strings as implementations will now silently call through to the slice
implementation. Some breakage occurred at std and beneath due to inherent
methods removed in favor of those in the slice traits and std doesn't use its
own prelude,
cc #18424