Don't ICE on bad extern paths #17991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let file = match loc.filename_str() { | ||
| Some(file) => file, | ||
| None => { | ||
| sess.err(format!("extern location is not a file: {}", |
There was a problem hiding this comment.
Maybe this could be "location for crate {} is not a file: {}" using self.crate_name.
There was a problem hiding this comment.
I formatted this error like the other ones in the closure. Should those be changed as well?
There was a problem hiding this comment.
Oh, I see. Changing them to include the crate name would make them more informative.
sfackler
force-pushed
the
extern-error
branch
from
069fa8f
to
84d1cbf
Compare
|
@huonw updated |
|
r=me with a test added |
|
@alexcrichton were you looking for something more than src/test/compile-fail/empty-extern-arg.rs? |
|
Wow, I should have just kept reading, sorry about that! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 13, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 29, 2024
… r=Veykril fix: Don't add reference when it isn't needed for the "Extract variable" assist I.e. don't generate `let var_name = &foo()`. Because it always irritates me when I need to fix that. Anything that creates a new value don't need a reference. That excludes mostly field accesses and indexing. I had a thought that we can also not generate a reference for fields and indexing as long as the type is `Copy`, but sometimes people impl `Copy` even when they don't want to copy the values (e.g. a large type), so I didn't do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17990