Refactor of readdir to not fail as much #17034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, NTFS and the low-level Windows API use UCS2 path names, not UTF-16. It's incorrect to simply skip over the file names. |
|
The proper solution is of course #12056 but this is a stopgap measure so that the test suite passes in the meantime. I'd argue it is better to skip invalid UTF-16 than fail the entire task. |
|
I'm a little wary of just skipping files in a directory, it's sure to bite someone later on down the road. For now could this return an error for the entire |
Fixes rust-lang#15279 Signed-off-by: Peter Atashian <[email protected]>
retep998
changed the title
|
PR has been modified to return an error instead of merely skipping over the invalid paths. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
… r=lnicola Document enabling the flatpak rust SDK extension Just having `org.freedesktop.Sdk.Extension.rust-stable` and `org.freedesktop.Sdk.Extension.llvm15` installed is not enough. `/usr/lib/sdk/rust-stable/bin` at least needs to be added to the `PATH`. In the case of VSCodium [ide-flatpak-wrapper](https://github.com/noonsleeper/ide-flatpak-wrapper) in included to do this.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
… r=lnicola Document enabling the flatpak rust SDK extension Just having `org.freedesktop.Sdk.Extension.rust-stable` and `org.freedesktop.Sdk.Extension.llvm15` installed is not enough. `/usr/lib/sdk/rust-stable/bin` at least needs to be added to the `PATH`. In the case of VSCodium [ide-flatpak-wrapper](https://github.com/noonsleeper/ide-flatpak-wrapper) in included to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15279
Based on #13338