Fix test compiling Fuchsia with rust-under-test - #162573
Draft
erickt wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu |
rustbot
added
A-CI
Collaborator
|
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
erickt
force-pushed
the
fix-fuchsia-tests
branch
2 times, most recently
from
September 10, 2026 04:05
a713911 to
fc8ed40
Compare
Contributor
Author
|
It looks like the |
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Fix test compiling Fuchsia with rust-under-test try-job: dist-various-2 try-job: x86_64-fuchsia
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
💔 Test for a03d4d5 failed: CI. Failed job:
|
erickt
force-pushed
the
fix-fuchsia-tests
branch
from
September 10, 2026 04:26
fc8ed40 to
f1cc882
Compare
Collaborator
|
The rustc-dev-guide subtree was changed. If your future PRs only touch the subtree, consider submitting them directly to rust-lang/rustc-dev-guide, which is where the document is primarily maintained (and has faster CI). |
Contributor
Author
|
@bors try |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Fix test compiling Fuchsia with rust-under-test try-job: dist-various-2 try-job: test-x86_64-fuchsia
This comment has been minimized.
This comment has been minimized.
Contributor
|
💔 Test for c09146d failed: CI. Failed jobs:
|
erickt
force-pushed
the
fix-fuchsia-tests
branch
from
September 10, 2026 04:35
f1cc882 to
4a68a46
Compare
erickt
marked this pull request as draft
September 10, 2026 04:36
Contributor
Author
|
Looks like I need to incorporate some changes from CI, so I switched this to a draft mode until I get the tests passing. @bors try |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
💔 Test for 4f9cc52 failed: CI. Failed job:
|
Contributor
Author
|
Kicking off another try run now that rust-lang/simpleinfra#1234 landed. @bors try test-x86_64-fuchsia |
Contributor
|
Unknown argument "test-x86_64-fuchsia". Did you mean to use |
Contributor
Author
|
@bors try jobs=test-x86_64-fuchsia |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Fix test compiling Fuchsia with rust-under-test try-job: test-x86_64-fuchsia
Contributor
|
💔 Test for fb68cd4 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Member
aarch64 is cheaper for us on a per-core basis (pricing is here, though it's just public prices: Line 93 in ca0a647 We shouldn't use too large an instance for auto, but try to aim for an instance that gets you <= 2 hour runtime so it doesn't become the slowest runner. |
erickt
force-pushed
the
fix-fuchsia-tests
branch
from
September 11, 2026 17:52
bf19a23 to
4ed0a2f
Compare
Contributor
Author
|
I think I shook out all the kinks and it should hopefully pass. If so, I'll rewrite the patch to target aarch64 since it is more cost effective. @bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Fix test compiling Fuchsia with rust-under-test try-job: dist-various-2 try-job: test-x86_64-fuchsia
Contributor
erickt
force-pushed
the
fix-fuchsia-tests
branch
2 times, most recently
from
September 11, 2026 20:51
9c73fe0 to
79359a4
Compare
Contributor
Author
|
@bors try jobs=test-aarch64-fuchsia,test-x86_64-fuchsia |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Fix test compiling Fuchsia with rust-under-test try-job: test-aarch64-fuchsia try-job: test-x86_64-fuchsia
This comment has been minimized.
This comment has been minimized.
The rust tests were disabled some time ago when fuchsia.googlesource.com was temporarily rate limiting git checkout requests during a high period of requests. This makes a number of attempts to avoid this issue: * It checks out Fuchsia with git filter `tree:0` to reduce download size. * It blocks downloading Fuchsia's Rust toolchain. * It adds a number of retries to requests. * It reduces the parallel git checkout threads. Since it has been a while since we updated the Fuchsia integration, it also updates: * Use the most recent commit [be532c]. * It updates to the clang commit [5e63f2]. * It updates to the Fuchsia SDK version 33.20260909.5.1. * It updates the ubuntu container to 26.04. * It renames the test job to `test-x86_64-fuchsia`. * It adds an aarch64 job `test-aarch64-fuchsia`. * The Fuchsia build system now requires shared libraries to be stripped. try-job: dist-various-2 try-job: test-aarch64-fuchsia try-job: test-x86_64-fuchsia [be532c]: https://fuchsia.googlesource.com/integration/+/be532c365aa6ba56b08ed684c0f8bb71960c18fd [5e63f2]: llvm/llvm-project@5e63f2c
erickt
force-pushed
the
fix-fuchsia-tests
branch
from
September 11, 2026 21:04
79359a4 to
bf6a0ac
Compare
Contributor
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run |
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Fix test compiling Fuchsia with rust-under-test try-job: dist-various-2 try-job: test-aarch64-fuchsia try-job: test-x86_64-fuchsia
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Contributor
|
💔 Test for 68acc6d failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
The rust tests for Fuchsia were disabled some time ago in #138690 when fuchsia.googlesource.com was temporarily rate limiting git checkout requests during a high period of requests. This makes a number of attempts to avoid this issue:
tree:0to reduce download size.Since it has been a while since we updated the Fuchsia integration, it also updates:
test-x86_64-fuchsia.test-aarch64-fuchsia.try-job: dist-various-2
try-job: test-aarch64-fuchsia
try-job: test-x86_64-fuchsia