Skip to content

Revert "Skip rustc book on i686" - #162553

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-rustc-book-skip
Sep 10, 2026
Merged

Revert "Skip rustc book on i686"#162553
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-rustc-book-skip

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Sep 9, 2026

Copy link
Copy Markdown
Member

Reverts #158379
This should not be needed anymore since #162288 merged

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 9, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-i686-msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
Revert "Skip rustc book on i686"


try-job: dist-i686-msvc
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

cc @mati865
r? @jieyouxu

@JonathanBrouwer
JonathanBrouwer marked this pull request as ready for review September 9, 2026 20:31
@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2026
@rust-bors

rust-bors Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 7486bdd (7486bdd489727121856f34bc2ffca3904827482c)
Base parent: 32ffad3 (32ffad32f4cdad86624f6ec46737f70d98a9a88d)

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8511054 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 10, 2026
…skip, r=jieyouxu

Revert "Skip rustc book on i686"

Reverts rust-lang#158379
This should not be needed anymore since rust-lang#162288 merged
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
Rollup of 5 pull requests

Successful merges:

 - #158191 (Suggest installing `rust-src` when standard library source is unavailable)
 - #162122 (Put manual calls of Enzyme intrinsics behind a feature gate)
 - #162553 (Revert "Skip rustc book on i686")
 - #162562 (Add regression test for higher-ranked fn pointer trait impl mismatch errors)
 - #162518 (Add a revision for previously fixed solver issue)
@rust-bors

rust-bors Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
…youxu

Revert "Skip rustc book on i686"

Reverts #158379
This should not be needed anymore since #162288 merged
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (to beta backports, which flaked out)

@rust-bors

rust-bors Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #162567.

rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
Rollup of 4 pull requests

Successful merges:

 - #162122 (Put manual calls of Enzyme intrinsics behind a feature gate)
 - #162553 (Revert "Skip rustc book on i686")
 - #162562 (Add regression test for higher-ranked fn pointer trait impl mismatch errors)
 - #162518 (Add a revision for previously fixed solver issue)
@rust-bors
rust-bors Bot merged commit 093f1e9 into rust-lang:main Sep 10, 2026
14 of 15 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 10, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
Rollup merge of #162553 - JonathanBrouwer:revert-rustc-book-skip, r=jieyouxu

Revert "Skip rustc book on i686"

Reverts #158379
This should not be needed anymore since #162288 merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants