Gate ELF code in metadata.rs for ELF only - #162542
Merged
Merged
Conversation
rustbot
added
S-waiting-on-author
Contributor
Please note our LLM Usage Policy. |
Contributor
Author
Thanks for the reminder. I updated the PR description to clarify the use of IBM Bob in this. |
xingxue-ibm
marked this pull request as ready for review
September 9, 2026 17:07
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @khyperia rustbot has assigned @khyperia. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 10, 2026
… r=khyperia Gate ELF code in metadata.rs for ELF only This PR gates ELF specific code for `BinaryFormat::Elf`. With this change, fallback for PowerPC64 on AIX is no longer needed. --------- Assisted-by: IBM Bob The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 10, 2026
… r=khyperia Gate ELF code in metadata.rs for ELF only This PR gates ELF specific code for `BinaryFormat::Elf`. With this change, fallback for PowerPC64 on AIX is no longer needed. --------- Assisted-by: IBM Bob The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Gate ELF code in metadata.rs for ELF only This PR gates ELF specific code for `BinaryFormat::Elf`. With this change, fallback for PowerPC64 on AIX is no longer needed. --------- Assisted-by: IBM Bob The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 5936bb7 failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 10, 2026
… r=khyperia Gate ELF code in metadata.rs for ELF only This PR gates ELF specific code for `BinaryFormat::Elf`. With this change, fallback for PowerPC64 on AIX is no longer needed. --------- Assisted-by: IBM Bob The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.
This was referenced Sep 10, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 6 pull requests Successful merges: - #161334 (Fix soundness issues in std::sys::pal::sgx::waitqueue::unsafe_list) - #162346 (rustdoc: add missing CCI union logic) - #162273 (doc: replace `exceeding_bitshifts` with `arithmetic_overflow`) - #162539 (Update wasip2/wasip3 libstd crate dependencies) - #162542 (Gate ELF code in metadata.rs for ELF only) - #162604 (Update windows-gnu support docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup merge of #162542 - xingxue-ibm:gate-elf-code-for-elf, r=khyperia Gate ELF code in metadata.rs for ELF only This PR gates ELF specific code for `BinaryFormat::Elf`. With this change, fallback for PowerPC64 on AIX is no longer needed. --------- Assisted-by: IBM Bob The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gates ELF specific code for
BinaryFormat::Elf. With this change, fallback for PowerPC64 on AIX is no longer needed.Assisted-by: IBM Bob
The issue was discovered by IBM Bob while checking changes for other things, and I personally verified the bug. Although the fix is trivial, I ran it through IBM Bob to make sure I wasn’t missing anything.