Make `run-make` testsuite work with other codegen backend than LLVM by GuillaumeGomez · Pull Request #162482 · rust-lang/rust

GuillaumeGomez · 2026-09-08T14:57:26Z

Needed for #159924.

Currently, we always run run-make testsuite with the codegen backend rustc was compiled with. However, in CI it's compiled with LLVM, so when we want to test with GCC (with --test-codegen-backend), it compiles rmake.rs with the GCC backend, but when running the test, it doesn't use the GCC backend since it just calls rustc. So to get around that, I now pass the codegen backend through the environment and set it in the rustc function of run_make_support.

To be noted that for now it's only for the rustc function, no other command uses it. Should I extend it right away for all commands (well, likely only cargo) or just rustc for now is enough?

r? @jieyouxu

rustbot · 2026-09-08T14:57:30Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

rustbot · 2026-09-08T14:57:34Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

GuillaumeGomez · 2026-09-08T14:58:34Z

Ah, let's set someone else then.

r? @Kobzol

rustbot · 2026-09-08T14:58:39Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Kobzol

Left one comment, otherwise looks reasonable, I agree that run-make tests should respect the selected codegen backend.

View changes since this review

GuillaumeGomez · 2026-09-08T15:21:05Z

Updated.

Kobzol · 2026-09-08T15:23:17Z

Thanks, looks good.

@bors r+

rust-bors · 2026-09-08T15:23:21Z

📌 Commit 5dffd45 has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

@jieyouxu

…r=Kobzol Make `run-make` testsuite work with other codegen backend than LLVM Needed for rust-lang#159924. Currently, we always run `run-make` testsuite with the codegen backend rustc was compiled with. However, in CI it's compiled with LLVM, so when we want to test with GCC (with `--test-codegen-backend`), it compiles `rmake.rs` with the GCC backend, but when running the test, it doesn't use the GCC backend since it just calls `rustc`. So to get around that, I now pass the codegen backend through the environment and set it in the `rustc` function of `run_make_support`. To be noted that for now it's only for the `rustc` function, no other command uses it. Should I extend it right away for all commands (well, likely only `cargo`) or just `rustc` for now is enough? r? @jieyouxu

GuillaumeGomez · 2026-09-08T16:08:21Z

Seems like I need to fix some tests first. :')

@bors r-

rust-bors · 2026-09-08T16:08:29Z

This pull request was unapproved.

This PR was contained in a rollup (#162486), which was unapproved.

View changes since this unapproval

GuillaumeGomez · 2026-09-08T16:52:55Z

We still have quite a few tests we need to fix in the GCC backend. For now, I marked them as ignored for the GCC backend. But it's nice since we have a new list of regression tests we'll be able to use. =D

Kobzol · 2026-09-08T17:01:46Z

Why only some tests have FIXMEs, the others are LLVM only? Anyway, feel free to r=me once PR CI is green :)

GuillaumeGomez · 2026-09-08T19:31:40Z

Why only some tests have FIXMEs, the others are LLVM only? Anyway, feel free to r=me once PR CI is green :)

Because the ones with the llvm components, I'm not sure they're relevant for gcc backend.

… works for them Limit some `run-make` tests to LLVM until GCC backend works for them

GuillaumeGomez · 2026-09-08T21:42:35Z

Seems like CI is happy, let's go. =D

@bors r=Kobzol

rust-bors · 2026-09-08T21:42:38Z

📌 Commit 21cfbad has been approved by Kobzol

It is now in the queue for this repository.

@jieyouxu

…r=Kobzol Make `run-make` testsuite work with other codegen backend than LLVM Needed for rust-lang#159924. Currently, we always run `run-make` testsuite with the codegen backend rustc was compiled with. However, in CI it's compiled with LLVM, so when we want to test with GCC (with `--test-codegen-backend`), it compiles `rmake.rs` with the GCC backend, but when running the test, it doesn't use the GCC backend since it just calls `rustc`. So to get around that, I now pass the codegen backend through the environment and set it in the `rustc` function of `run_make_support`. To be noted that for now it's only for the `rustc` function, no other command uses it. Should I extend it right away for all commands (well, likely only `cargo`) or just `rustc` for now is enough? r? @jieyouxu

Rollup of 6 pull requests Successful merges: - #162482 (Make `run-make` testsuite work with other codegen backend than LLVM) - #161587 (Avoid invalid suggestion in case of macro expansion without inferrable generic type) - #162363 (Use correct `dir_path` when parsing module from path) - #162408 (add crashtests [7/N]) - #162502 (triagebot: Subscribe me to amdgpu changes) - #162505 (Revert "fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia")

@jieyouxu

Rollup merge of #162482 - GuillaumeGomez:run-make-backends, r=Kobzol Make `run-make` testsuite work with other codegen backend than LLVM Needed for #159924. Currently, we always run `run-make` testsuite with the codegen backend rustc was compiled with. However, in CI it's compiled with LLVM, so when we want to test with GCC (with `--test-codegen-backend`), it compiles `rmake.rs` with the GCC backend, but when running the test, it doesn't use the GCC backend since it just calls `rustc`. So to get around that, I now pass the codegen backend through the environment and set it in the `rustc` function of `run_make_support`. To be noted that for now it's only for the `rustc` function, no other command uses it. Should I extend it right away for all commands (well, likely only `cargo`) or just `rustc` for now is enough? r? @jieyouxu

rustbot assigned jieyouxu Sep 8, 2026

rustbot assigned Kobzol and unassigned jieyouxu Sep 8, 2026

Kobzol reviewed Sep 8, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest/run_make.rs Outdated

Comment thread src/tools/run-make-support/src/external_deps/rustc.rs Outdated

Make run-make work with other codegen backend than LLVM

5dffd45

GuillaumeGomez force-pushed the run-make-backends branch from e29a8ed to 5dffd45 Compare September 8, 2026 15:20

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026

JonathanBrouwer mentioned this pull request Sep 8, 2026

Rollup of 7 pull requests #162486

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2026

GuillaumeGomez force-pushed the run-make-backends branch from f6683e8 to 8d586e7 Compare September 8, 2026 16:52

This comment has been minimized.

Sign in to view

Ignore the GCC backend in some run-make tests until the GCC backend…

21cfbad

… works for them Limit some `run-make` tests to LLVM until GCC backend works for them

GuillaumeGomez force-pushed the run-make-backends branch from 8d586e7 to 21cfbad Compare September 8, 2026 19:34

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026

Zalathar mentioned this pull request Sep 9, 2026

Rollup of 6 pull requests #162510

Merged

mu001999 mentioned this pull request Sep 9, 2026

Rollup of 6 pull requests #162511

Closed

rust-bors Bot merged commit b604379 into rust-lang:main Sep 9, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 9, 2026

GuillaumeGomez deleted the run-make-backends branch September 9, 2026 09:51

GuillaumeGomez mentioned this pull request Sep 9, 2026

Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc #159924

Open

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Sep 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

GuillaumeGomez commented Sep 8, 2026

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Sep 8, 2026

Uh oh!

Kobzol commented Sep 8, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

GuillaumeGomez commented Sep 8, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

GuillaumeGomez commented Sep 8, 2026

Uh oh!

Kobzol commented Sep 8, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Sep 8, 2026

Uh oh!

GuillaumeGomez commented Sep 8, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GuillaumeGomez commented Sep 8, 2026 •

edited by rustbot

Loading

Kobzol left a comment •

edited by rustbot

Loading