Rollup of 4 pull requests by JonathanBrouwer · Pull Request #162362 · rust-lang/rust

JonathanBrouwer · 2026-09-06T09:20:32Z

Successful merges:

remove more trivial regions in evaluate_added_goals_and_make_canonical_response #162032 (remove more trivial regions in evaluate_added_goals_and_make_canonical_response)
Add #[track_caller] to signed integer div/rem methods #161607 (Add #[track_caller] to signed integer div/rem methods)
Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716" #162339 (Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716")
Revise documentation of NumBuffer and format_into(). #162158 (Revise documentation of NumBuffer and format_into().)

The unsigned counterparts got the attribute in #724fe8f, but the signed side was missed, so panics like `0i32.wrapping_div(0)` point at the library source instead of the caller. Also covers overflowing_div_euclid, which the issue missed but wrapping_div_euclid delegates to, so it would still report the wrong location without it.

The previous documentation was, in my opinion, overly focused on the implementation of these items, rather than how and when to use them. This new documentation: * Begins the `format_into()` documentation with what it does when called. * Specifies that `format_into()` is a specialized alternative to the more commonly used `Display`. * Specifies that `NumBuffer` cannot be read or otherwise used by itself.

…ke_canonical_response

…oc-mergeable, r=Kobzol,jieyouxu" This reverts commit a69a632, reversing changes made to c33d8f3.

…uVanilla remove more trivial regions in evaluate_added_goals_and_make_canonical_response cc rust-lang#161575. I don't think it *fixes* the issue per se, since the most principled fix would be to just deny unconstrained lifetime args like we do for types and consts already. At the very least, though, it Makes Things Go Faster. In the example from rust-lang#161575 (comment), each `'unconstrained` appears only once in the entire response: in the rhs of the `'a: 'unconstrained#N` bound. Since they are mentioned nowhere else and are created only when proving our own nested goals, these outlives constraints are all satisfiable by setting `'unconstrained := 'empty`, which tells us nothing about `'a`. Therefore, (I think) that makes it safe to treat all of these constraints as trivial and drop them entirely, drop all of these requirements entirely, similar to what we already do with reflexive or duplicate region constraints. In other words, if a `ReVar` appears only once in the entire response, and that place is the rhs of an outlives constraint, then it is safe to drop that constraint. I'm a little worried about the perf impact of the visitor on "normal" code, but fwiw even a 100-deep nested version of the reproducer compiles in about 0.05s on my machine. r? lcnr

…div, r=Mark-Simulacrum Add #[track_caller] to signed integer div/rem methods Fixes rust-lang#139672 The unsigned div/rem methods got #[track_caller] in 724fe8f but the signed side was missed. This adds it to the 8 signed methods listed in the issue, including overflowing_div_euclid which the issue missed but wrapping_div_euclid delegates to. No test added, matching the unsigned side. cg_gcc doesn't propagate track_caller through inlined div/rem yet so a runtime check would fail on the gcc-core-tests CI job.

@Kobzol

…obzol Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs rust-lang#161716" cc rust-lang#162334. It seems that rust-lang#161716 still has some issues with combining cross-crate info? Let's revert for now and reland once we figure out why we are regressing the search results 🤔 It's not obvious to me. I built `rustc-docs` dist component locally, and at least locally with rust-lang#161716 reverted I can find `rustc::ast::Attribute` "normally" from the search results. This reverts commit a69a632, reversing changes made to c33d8f3. This also reverts rust-lang#162318, since rust-lang#162318 fixes an regression introduced in rust-lang#162334. r? @Kobzol (or notriddle/bootstrap/rustdoc) cc @notriddle

@rustbot

Revise documentation of `NumBuffer` and `format_into()`. The previous documentation was, in my opinion, overly focused on the implementation of these items, rather than how and when to use them. In particular, this new documentation: * Begins the `format_into()` documentation with what it does when called. * Specifies that `format_into()` is a specialized alternative to the more commonly used `Display`. * Specifies that `NumBuffer` cannot be read or otherwise used by itself. @rustbot label +A-docs

JonathanBrouwer · 2026-09-06T09:20:39Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

rust-bors · 2026-09-06T09:20:41Z

📌 Commit 3b6ec47 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-09-06T09:20:46Z

⌛ Trying commit 3b6ec47 with merge 2519bbe…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/34024390054

Rollup of 4 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2

JonathanBrouwer · 2026-09-06T09:21:02Z

@bors try cancel
oops that's not very useful

rust-bors · 2026-09-06T09:21:05Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/34024390054

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

rust-bors · 2026-09-06T12:30:09Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 8m 55s
Pushing 7cef43f to main...

github-actions · 2026-09-06T12:33:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 46a266b (parent) -> 7cef43f (this PR)

Test differences

Show 1811 test diffs

Stage 0

core::builder::tests::snapshot::dist_compiler_docs: [missing] -> pass (J2)
core::builder::tests::snapshot::doc_compiler_with_tools: pass -> [missing] (J2)

Stage 1

[ui (polonius)] tests/ui/traits/next-solver/no-dedup-universes.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/next-solver/no-dedup-universes.rs: [missing] -> pass (J3)

Stage 2

[ui] tests/ui/traits/next-solver/no-dedup-universes.rs: [missing] -> pass (J0)

Additionally, 1806 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7cef43fbb6862a20766f206ed6fec78124922d2c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-msvc-ext2: 1h 54m -> 1h 12m (-36.3%)
x86_64-gnu-gcc: 1h 22m -> 52m 46s (-36.2%)
x86_64-gnu-stdlib-semver-check: 16m 26s -> 10m 40s (-35.1%)
x86_64-mingw-1: 2h 15m -> 3h (+33.5%)
dist-loongarch64-musl: 1h 24m -> 1h 52m (+33.3%)
x86_64-gnu-gcc-core-tests: 17m 7s -> 11m 26s (-33.2%)
x86_64-gnu-llvm-22-1: 1h 16m -> 51m 15s (-32.9%)
pr-check-1: 39m 17s -> 27m 6s (-31.0%)
dist-x86_64-illumos: 1h 28m -> 1h 54m (+30.0%)
i686-gnu-nopt-1: 2h 13m -> 1h 33m (-29.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-09-06T13:37:39Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#162032	remove more trivial regions in evaluate_added_goals_and_mak…	`117b3846de1ef24cf869434d04abdbddc4e66384` (link)
#161607	Add #[track_caller] to signed integer div/rem methods	`5033be0d214394f7e3c8b0ec028399ad18c5db13` (link)
#162339	Revert "bootstrap: Enable rustdoc mergeable CCI for std and…	`1451a27fb43bd26dd9d3b7a22b09b1014ff0f920` (link)
#162158	Revise documentation of `NumBuffer` and `format_into()`.	`dd00563de72503068ebcf67b5a79f2bf4f3b4e8d` (link)

parent commit: 46a266b9fb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-09-06T15:22:33Z

Finished benchmarking commit (7cef43f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.4%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[2.6%, 4.5%]	3
Improvements ✅ (primary)	-1.4%	[-2.7%, -0.7%]	6
Improvements ✅ (secondary)	-2.6%	[-2.9%, -1.9%]	8
All ❌✅ (primary)	-1.4%	[-2.7%, -0.7%]	6

Cycles

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 478.283s -> 478.023s (-0.05%)
Artifact size: 403.38 MiB -> 404.16 MiB (0.19%)

kianalikasana and others added 8 commits August 24, 2026 11:00

treat more kinds of regions as trivial in evaluate_added_goals_and_ma…

e9ab50c

…ke_canonical_response

Revert "Auto merge of rust-lang#161716 - notriddle:remake-bootstrap-d…

c84edb3

…oc-mergeable, r=Kobzol,jieyouxu" This reverts commit a69a632, reversing changes made to c33d8f3.

rust-bors Bot added the rollup A PR which is a rollup label Sep 6, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026

rust-bors Bot mentioned this pull request Sep 6, 2026

remove more trivial regions in evaluate_added_goals_and_make_canonical_response #162032

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2026

rust-bors Bot merged commit 7cef43f into rust-lang:main Sep 6, 2026
14 of 15 checks passed

rustbot added this to the 1.100.0 milestone Sep 6, 2026

rust-bors Bot mentioned this pull request Sep 6, 2026

bootstrap: Include feature-gated items in bootstrap tool docs #161900

Open

rust-bors Bot mentioned this pull request Sep 6, 2026

-Znext-solver Allow method calls on chains of assoc types of not-yet defined opaque types #161414

Draft

Navigation Menu

Uh oh!

Uh oh!

Rollup of 4 pull requests - #162362

Rollup of 4 pull requests#162362
rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-CyBhnoS

JonathanBrouwer commented Sep 6, 2026 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 6, 2026

Stage 0

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-timer commented Sep 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Sep 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 6, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 6, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Sep 6, 2026

Uh oh!

rust-timer commented Sep 6, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JonathanBrouwer commented Sep 6, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Sep 6, 2026 •

edited

Loading