Skip to content

experient to understand MaybeDangling perf regression #162357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RalfJung wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

experient to understand MaybeDangling perf regression #162357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f367d69
experient to understand MaybeDangling perf regression
RalfJung Sep 6, 2026
ec999ed
what if we remove this code entirely
RalfJung Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions compiler/rustc_middle/src/ty/layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,21 +1165,6 @@ where
}
}

// Patch result if we are a MaybeDangling-like type.
if this.ty.is_like_maybe_dangling()
&& let Some(info) = result
{
result = Some(PointeeInfo {
// Mark the pointer as raw
// (thus removing noalias/readonly/etc in case of the llvm backend)
safe: None,
// Make sure we don't assert dereferenceability of the pointer.
size: Size::ZERO,
// Preserve the alignment assertion! That is required even inside `MaybeDangling`.
align: info.align,
});
}

result
}
};
Expand Down
Loading