compiler-builtins subtree update - #162119
Merged
Merged
Conversation
The git registry now takes long enough to download that the 10 minute timeout is hit.
Since 1.97, linker warnings can be denied via rustc.
This is the first version with LLVM23.
This was added as part of the original test infrastructure at
8e161a791a89 ("Expand and refactor teting infrastructure") but there
doesn't seem to be any reason to keep this restriction; qemu should
handle the threads fine.
With LLVM 23, containing f128 abi fixes, this now works
Benchmarks are designed to run in release mode so these can be pretty slow. Running once with `release-checked` is sufficient.
Fixes rust-lang/compiler-builtins#1271 by removing `#[aapcs_on_arm]`: `compiler-rt` only does the equivalent on ARM soft-float targets where the `"C"` ABI is already AAPCS. [ add PR description to commit - Trevor ]
This updates the rust-version file to f7d782a.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@f7d782a Filtered ref: rust-lang/compiler-builtins@1ebbb4d Upstream diff: rust-lang/rust@2c39ff4...f7d782a This merge was created using https://github.com/rust-lang/josh-sync.
Some PRs want to make use of newer features.
This reverts commit 4feca6f3e62151f5cedacf3a5877b6200fb5af43. The patch has landed in the 23.1-2026-07-22 branch.
This should make it fall back to a system-wide cargo-nextest install or running the tests without nextest, which is probably still faster than building nextest from source.
This error started appearing in the latest nightly:
error: the loop variable `i` is used to index `ret.0`
--> builtins-test/tests/mem.rs:149:14
|
149 | for i in 0..N {
| ^^^^
|
note: for this index operation
--> builtins-test/tests/mem.rs:150:9
|
150 | ret.0[i] = i as u8;
| ^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/main/index.html#needless_range_loop
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_range_loop)]`
help: consider using an iterator and `.enumerate()`
|
149 - for i in 0..N {
149 + for (i, <item>) in ret.0.iter_mut().enumerate().take(N) {
|
Prepare for reuse elsewhere.
Prepare for reuse elsewhere.
Remove a mostly redundant type. There are some minor differences in the `memcmp` benches because the slices are now the same length (`let s2: &[u8] = black_box(&v2[1..]);` was trimming one).
We'd like to this add new `s390x` runner to `compiler-builtins`. This new runner is provided by Canonical. After some iteration alongside with Canonical folks, the `large` runner offers hardware spec similar to the existing s390x provided by IBM and [delivers similar build times](https://github.com/rust-lang/compiler-builtins/actions/runs/31516313575/job/93862267593?pr=1227). Moreover, it runs on ubuntu-26.04 rather than ubuntu-24.04, and it features a Github integration more friendly to `t-infra`, since the related Github App requires less permissions to run. We don't need to remove the s390x IBM runners right now. We propose having both s390x runners running side by side for a while and circle back after a few PRs, sticking with the Canonical one afterwards if everything goes well.
There doesn't seem to be a straightforward way to build and test this target anymore. Disable it for now since CI is broken. Link: rust-lang/compiler-builtins#1306
This updates the rust-version file to 45f215f.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 45f215f Filtered ref: 2e55b234943f43e4b52bbfba006744b9a4318124 Upstream diff: rust-lang/rust@f7d782a...45f215f This merge was created using https://github.com/rust-lang/josh-sync.
rustbot
removed
the
S-waiting-on-author
Collaborator
|
Contributor
|
@bors r+ p=1 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
|
@bors rollup=never I've had annoying syncs back from the way Josh handles rollups. Hopefully resolved but may as well be cautious... |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 1, 2026
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@e91a3d3. Created using https://github.com/rust-lang/josh-sync. r? @ghost
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 523d280 failed: CI. Failed job:
|
Member
Author
|
Can’t seem to see the logs, spurious? @bors try jobs=dist-ohos-x86_64 |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 2, 2026
compiler-builtins subtree update try-job: dist-ohos-x86_64
Member
Author
|
Ah I see now
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing edc52f8 (parent) -> c25253f (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c25253fac451fff60fb5b6c0b2c64d60f628c7cd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (c25253f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.1%, secondary 1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.0%, secondary -3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 472.928s -> 497.549s (5.21%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree update of
compiler-builtinsto rust-lang/compiler-builtins@e91a3d3.Created using https://github.com/rust-lang/josh-sync.
r? @ghost