Skip to content

docs(num): clarify conditions under which error occurs in impl TryFrom<int> for int #162076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Sep 3, 2026
Merged

docs(num): clarify conditions under which error occurs in impl TryFrom<int> for int #162076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions library/core/src/convert/num.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@ macro_rules! impl_try_from_unbounded {
type Error = TryFromIntError;

/// Tries to create the target number type from a source
/// number type. This returns an error if the source value
/// is outside of the range of the target type.
/// number type. This never returns an error.
#[inline]
fn try_from(value: $source) -> Result<Self, Self::Error> {
Ok(value as Self)
Expand All @@ -356,7 +355,7 @@ macro_rules! impl_try_from_lower_bounded {

/// Tries to create the target number type from a source
/// number type. This returns an error if the source value
/// is outside of the range of the target type.
#[doc = concat!("is less than [`", stringify!($target), "::MIN`].")]
#[inline]
fn try_from(u: $source) -> Result<Self, Self::Error> {
if u >= 0 {
Expand All @@ -379,7 +378,7 @@ macro_rules! impl_try_from_upper_bounded {

/// Tries to create the target number type from a source
/// number type. This returns an error if the source value
/// is outside of the range of the target type.
#[doc = concat!("is greater than [`", stringify!($target), "::MAX`].")]
#[inline]
fn try_from(u: $source) -> Result<Self, Self::Error> {
if u > (Self::MAX as $source) {
Expand Down
Loading