Fix toml syntax in bors config - #162016
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
|
Member
Author
|
(Found this while trying to use the new value in #159628 (comment), which failed to start the runner since bors is still using the old config file -- or so I assume). |
Member
Author
|
@bors r+ p=10 Since I'm pretty sure this has to land before the next bors restart (which isn't entirely in our control; AWS restarts bors periodically for patching of the underlying compute), bumping priority. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Kobzol
approved these changes
Aug 30, 2026
Member
There was a problem hiding this comment.
Oh, I saw that in the logs, and then totally forgot about it 🤦♂️ Thanks.
@bors r+ p=1
Contributor
Member
|
@bors p=10 (race condition :) ) |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 30, 2026
Fix toml syntax in bors config bors production is logging "Could not deserialize repository config: missing comma between key-value pairs, expected `,`" for at least a week (since landing #161562, I think). I assume it would fail to start if restarted? (Reproducible here: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=9e7d78b0ae002de5d73c9c9f8f518f38). I think we'll want to follow up to gate bors *merging* a PR breaking the toml syntax, I cut rust-lang/bors#829 to track that. r? @Kobzol
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 7e758f3 failed: CI. Failed job:
|
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2e071b2 (parent) -> 9085017 (this PR) Test differencesShow 5 test diffs5 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 90850177249efe0321573c569aec5d12b257f8d6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (9085017): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 475.013s -> 475.19s (0.04%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bors production is logging "Could not deserialize repository config: missing comma between key-value pairs, expected
," for at least a week (since landing #161562, I think). I assume it would fail to start if restarted? (Reproducible here: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=9e7d78b0ae002de5d73c9c9f8f518f38).I think we'll want to follow up to gate bors merging a PR breaking the toml syntax, I cut rust-lang/bors#829 to track that.
r? @Kobzol