Output tests/debuginfo raw JSON data on failure in CI - #162002
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
|
Member
|
Thanks! Do you have a link to a job where this happened, so I can take a look at it? In general, this is a nice improvement, though not perfect by far (but that is for follow-up PRs). If this happens for multiple tests and/or OSes, it would be annoying to manually update all that. I wonder if we could generate a single git patch file that could then be updated as a GitHub Actions artifact, and after download you could just |
Contributor
Author
|
Should be this one: #161574 (comment) Though that run didnt have the "use this to bless" tip, just the raw json. |
Member
|
Thanks. It is a bit non-trivial to copy, but better than nothing. Thanks! Let's land this as an initial implementation. @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 31, 2026
Output `tests/debuginfo` raw JSON data on failure in CI As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`). It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it. r? @Kobzol , @jieyouxu
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup of 5 pull requests Successful merges: - #161556 (document some rustc_dump attributes) - #161353 (Add test for parallel compiler reproducible build) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 31, 2026
Output `tests/debuginfo` raw JSON data on failure in CI As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`). It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it. r? @Kobzol , @jieyouxu
This was referenced Aug 31, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #162002 - Walnut356:json_dump, r=Kobzol Output `tests/debuginfo` raw JSON data on failure in CI As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`). It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it. r? @Kobzol , @jieyouxu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use
--bless).It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it.
r? @Kobzol , @jieyouxu