rustdoc: fix lint cargo::non_kebab_case_bins - #161843
Merged
Merged
Conversation
``` warning: binary `rustdoc_tool_binary` should have a kebab-case name | 1 | /checkout/obj/build/x86_64-unknown-linux-gnu/bootstrap-tools/.../rustdoc_tool_binary | ^^^^^^^^^^^^^^^^^^^ | = note: `cargo::non_kebab_case_bins` is set to `warn` by default help: to change the binary name to `rustdoc-tool-binary`, convert `bin.name` --> src/tools/rustdoc/Cargo.toml:10:8 | 10 - name = "rustdoc_tool_binary" 10 + name = "rustdoc-tool-binary" | warning: `rustdoc-tool` (manifest) generated 1 warning ``` See <https://triage.rust-lang.org/gha-logs/rust-lang/rust/98030530980#L2026-08-26T03:05:00.5389265Z-L2026-08-26T03:05:00.5392627Z>
Collaborator
|
rustbot has assigned @lolbinarycat. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-review
weihanglo
commented
Aug 27, 2026
| // the wrong rustdoc being executed. To avoid the conflicting rustdocs, we name the "tool" | ||
| // rustdoc a different name. | ||
| tool: "rustdoc_tool_binary", | ||
| tool: "rustdoc-tool-binary", |
Member
Author
There was a problem hiding this comment.
I am not sure if the old underscore name is used elsewhere though.
Member
There was a problem hiding this comment.
I believe this is only a bootstrap implementation detail
jieyouxu
approved these changes
Aug 27, 2026
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Rollup of 7 pull requests Successful merges: - #161034 (Add SVE-accelerated Vec::retain_mut for aarch64) - #161628 (interpret: ensure that calls via no-unwind ABIs do not unwind) - #161012 (borrowck: Normalize non-rigid aliases in NLL type relating) - #161691 (Assorted bootstrap config refactors (part 1/N)) - #161813 (Change `is_eligible_for_coverage` from a hook to a query) - #161842 (chore: fix cargo lints) - #161843 (rustdoc: fix lint `cargo::non_kebab_case_bins`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Rollup merge of #161843 - weihanglo:rustdoc-cargo-lints, r=jieyouxu rustdoc: fix lint `cargo::non_kebab_case_bins` ``` warning: binary `rustdoc_tool_binary` should have a kebab-case name | 1 | /checkout/obj/build/x86_64-unknown-linux-gnu/bootstrap-tools/.../rustdoc_tool_binary | ^^^^^^^^^^^^^^^^^^^ | = note: `cargo::non_kebab_case_bins` is set to `warn` by default help: to change the binary name to `rustdoc-tool-binary`, convert `bin.name` --> src/tools/rustdoc/Cargo.toml:10:8 | 10 - name = "rustdoc_tool_binary" 10 + name = "rustdoc-tool-binary" | warning: `rustdoc-tool` (manifest) generated 1 warning ``` See <https://triage.rust-lang.org/gha-logs/rust-lang/rust/98030530980#L2026-08-26T03:05:00.5389265Z-L2026-08-26T03:05:00.5392627Z> This was found in <#161789>.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 28, 2026
Rollup of 7 pull requests Successful merges: - rust-lang/rust#161034 (Add SVE-accelerated Vec::retain_mut for aarch64) - rust-lang/rust#161628 (interpret: ensure that calls via no-unwind ABIs do not unwind) - rust-lang/rust#161012 (borrowck: Normalize non-rigid aliases in NLL type relating) - rust-lang/rust#161691 (Assorted bootstrap config refactors (part 1/N)) - rust-lang/rust#161813 (Change `is_eligible_for_coverage` from a hook to a query) - rust-lang/rust#161842 (chore: fix cargo lints) - rust-lang/rust#161843 (rustdoc: fix lint `cargo::non_kebab_case_bins`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
https://triage.rust-lang.org/gha-logs/rust-lang/rust/98030530980#L2026-08-26T03:05:00.5389265Z-L2026-08-26T03:05:00.5392627Z
This was found in #161789.