Add missing option to -Zself-profile-event help message as well as information about what the default options are - #161821
Merged
rust-bors[bot] merged 2 commits intoSep 9, 2026
Conversation
…ptions to help message The `query-cache-hit-count` option was forgotten to be added to the help text when it was added. The new help text also documents which of the options are part of `default`, and now conveys the information that `args` is also a compound/group option as well as what it contains.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
CI decided not to run at all 🧐, I’ll try reopening… |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
steffahn
changed the title
-Zself-profile-event option to help message as well as information about what the default options are-Zself-profile-event help message as well as information about what the default options are
tiif
requested changes
Sep 6, 2026
| @@ -2843,8 +2843,11 @@ written to standard error output)"), | |||
Member
There was a problem hiding this comment.
This path seems to be outdated and I think it should be compiler/rustc_data_structures/src/profiling.rs, would you like to also fix it in current PR?
Member
Author
There was a problem hiding this comment.
sure, I'm happy to fix that ≽^⎚-⎚^≼
rustbot
added
S-waiting-on-author
Member
Author
|
(you'll also have to |
Member
Author
|
Addressed the nit; also added ⋯ I could also squash this if preferred (feel free to @rustbot ready |
rustbot
added
S-waiting-on-review
tiif
approved these changes
Sep 9, 2026
Member
There was a problem hiding this comment.
i didn't notice the src/, thanks again for catching that! <3
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
…uwer Rollup of 5 pull requests Successful merges: - #162470 (Subtree sync for rustc_codegen_cranelift) - #161734 (miri: enforce proper types for c-variadic arguments in shims) - #161821 (Add missing option to `-Zself-profile-event` help message as well as information about what the default options are) - #162453 (Minimize `DiagCtxt` methods) - #162528 (Add a mention to docs about promoting and demoting platform support)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Rollup merge of #161821 - steffahn:self-profile-help-message, r=tiif Add missing option to `-Zself-profile-event` help message as well as information about what the default options are The `query-cache-hit-count` option was forgotten to be added to the help text when it was added. The new help text also documents which of the options are part of `default`, and now conveys the information that `args` is also a compound/group option and what it contains.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#162470 (Subtree sync for rustc_codegen_cranelift) - rust-lang/rust#161734 (miri: enforce proper types for c-variadic arguments in shims) - rust-lang/rust#161821 (Add missing option to `-Zself-profile-event` help message as well as information about what the default options are) - rust-lang/rust#162453 (Minimize `DiagCtxt` methods) - rust-lang/rust#162528 (Add a mention to docs about promoting and demoting platform support)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
query-cache-hit-countoption was forgotten to be added to the help text when it was added.The new help text also documents which of the options are part of
default, and now conveys the information thatargsis also a compound/group option and what it contains.