Make `tcx.def_id_partial_cmp` public by blyxyas · Pull Request #161786 · rust-lang/rust

blyxyas · 2026-08-25T21:46:28Z

This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is).

Related to Clippy performance.

This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is).

rustbot · 2026-08-25T21:46:34Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler, types
compiler, types expanded to 75 candidates
Random selection from 16 candidates

davidtwco · 2026-09-04T13:24:35Z

@bors r+ rollup

rust-bors · 2026-09-04T13:24:38Z

📌 Commit 2678332 has been approved by davidtwco

It is now in the queue for this repository.

…blic, r=davidtwco Make `tcx.def_id_partial_cmp` public This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is). Related to Clippy performance.

Rollup of 25 pull requests Successful merges: - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8)) - #159792 (A more readable debug map for IndexMaps) - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment) - #161900 (bootstrap: Include feature-gated items in bootstrap tool docs) - #161940 (Promote `wasm32-wasip3` to a tier 2 target) - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1)

…blic, r=davidtwco Make `tcx.def_id_partial_cmp` public This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is). Related to Clippy performance.

Rollup of 25 pull requests Successful merges: - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8)) - #159792 (A more readable debug map for IndexMaps) - #160745 (make closures act like MaybeDangling) - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment) - #161940 (Promote `wasm32-wasip3` to a tier 2 target) - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1)

…blic, r=davidtwco Make `tcx.def_id_partial_cmp` public This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is). Related to Clippy performance.

Rollup of 27 pull requests Successful merges: - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8)) - #159792 (A more readable debug map for IndexMaps) - #160745 (make closures act like MaybeDangling) - #161940 (Promote `wasm32-wasip3` to a tier 2 target) - #162030 (Prevent `--test` to be used in `rustdoc-html` testsuite) - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1)

…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

…blic, r=davidtwco Make `tcx.def_id_partial_cmp` public This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is). Related to Clippy performance.

…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

Rollup merge of #161786 - blyxyas:make-def_id_partial_cmp-public, r=davidtwco Make `tcx.def_id_partial_cmp` public This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is). Related to Clippy performance.

…uwer Rollup of 25 pull requests Successful merges: - rust-lang/rust#162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - rust-lang/rust#162179 (type system const items via direct rhs) - rust-lang/rust#162255 (let people change rustc-dev-guide in-tree) - rust-lang/rust#162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - rust-lang/rust#162277 (Introduce `rustc_middle::middel::resolve`) - rust-lang/rust#162285 (box: fixup map/try_map deallocate calls) - rust-lang/rust#162286 (string: don't unwind prematurely) - rust-lang/rust#162289 (alloc: a bunch of safety comments) - rust-lang/rust#162290 (abby test DSL: AliasTyOutlivesViaEnv) - rust-lang/rust#162292 (Update `askama` version to `0.16.1`) - rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - rust-lang/rust#160906 (Suggest usize instead of placeholder type for array length constants) - rust-lang/rust#160936 (traits: Represent live alias arguments as bitsets) - rust-lang/rust#161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - rust-lang/rust#161400 (Improve diagnostics for references to closures) - rust-lang/rust#161656 (Suggest mutable references for FnMut closure arguments) - rust-lang/rust#161711 (Add more splat fn type tests) - rust-lang/rust#161786 (Make `tcx.def_id_partial_cmp` public) - rust-lang/rust#161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - rust-lang/rust#162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - rust-lang/rust#162212 (Implement `Rng` for `Box`) - rust-lang/rust#162246 (Fix incorrect meta span) - rust-lang/rust#162266 (std: fix typo) - rust-lang/rust#162291 (Add regression test from 1.98.1) - rust-lang/rust#162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

Make tcx.def_id_partial_cmp public

2678332

This is mainly because it would be very useful in Clippy to have a fast way to check if two DefIds are related (and what that relation is).

rustbot assigned davidtwco Aug 25, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2026

davidtwco approved these changes Sep 4, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162297

Closed

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162298

Closed

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162300

Closed

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 28 pull requests #162307

Closed

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 27 pull requests #162308

Closed

JonathanBrouwer mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162310

Merged

Zalathar mentioned this pull request Sep 5, 2026

Rollup of 20 pull requests #162317

Closed

rust-bors Bot merged commit 39a8bd6 into rust-lang:main Sep 5, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 5, 2026

Navigation Menu

Uh oh!

Uh oh!

Make `tcx.def_id_partial_cmp` public - #161786

Make `tcx.def_id_partial_cmp` public#161786
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
blyxyas:make-def_id_partial_cmp-public

blyxyas commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

davidtwco commented Sep 4, 2026

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

blyxyas commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

davidtwco commented Sep 4, 2026

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants