interpret: fix after_local_read handling - #161646
Merged
Merged
Conversation
Collaborator
|
Some changes occurred to the CTFE machinery
cc @rust-lang/miri Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
commented
Aug 24, 2026
Member
|
@rustbot reroll |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
after_local_read
branch
from
August 24, 2026 15:33
5f365e7 to
ed5a3c9
Compare
RalfJung
force-pushed
the
after_local_read
branch
from
August 24, 2026 15:38
ed5a3c9 to
9a4f00e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
RalfJung
force-pushed
the
after_local_read
branch
from
August 24, 2026 15:41
9a4f00e to
1071f50
Compare
Member
Author
|
Since Oli is on vacation This turned now into a bit of a refactor of how we handle "not-real accesses". |
RalfJung
force-pushed
the
after_local_read
branch
from
August 24, 2026 17:02
5e9a5e2 to
531e812
Compare
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 25, 2026
interpret: fix after_local_read handling `after_local_read` handling was wrong in two ways: - Contrary to what was documented, we invoked it for all reads of locals, not just reads of locals that have their values stored as immediates (without memory). - Miri effectively ignored the `frame` we are passing to it. And indeed we never want this called on anything but the current frame, also for consistency with the corresponding write hook. So let's restrict `local_to_op` to the current frame. Debuggers/visualizers should be able to use the existing method on `LocalState` that Miri also needs for its provenance visitor. Its name was not sufficiently scary for skipping access hooks, so I also overhauled how we name these "fake"/"ghost" access related APIs.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup of 9 pull requests Successful merges: - #160533 (dirfd dir operations (3/4)) - #161294 (add crashtests [6/N]) - #160392 (library: motor: bump moto-rt ABI ver to 17) - #161646 (interpret: fix after_local_read handling) - #160819 (Rework `div_ceil` for nonzero integers) - #161591 (run `classify-runtime-const` test for `f128`) - #161680 (renovate: add lockfile update warning) - #161702 (Use `drop_guard` in some places in {core,alloc,std}) - #161709 (Stop rustfmt deleting attributes in fn params)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
…uwer Rollup of 10 pull requests Successful merges: - #160533 (dirfd dir operations (3/4)) - #161294 (add crashtests [6/N]) - #160392 (library: motor: bump moto-rt ABI ver to 17) - #161646 (interpret: fix after_local_read handling) - #161682 (Update books) - #160819 (Rework `div_ceil` for nonzero integers) - #161204 (core: Make funnel shifts panic only if overflow checks are enabled) - #161591 (run `classify-runtime-const` test for `f128`) - #161680 (renovate: add lockfile update warning) - #161709 (Stop rustfmt deleting attributes in fn params)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup merge of #161646 - RalfJung:after_local_read, r=saethlin interpret: fix after_local_read handling `after_local_read` handling was wrong in two ways: - Contrary to what was documented, we invoked it for all reads of locals, not just reads of locals that have their values stored as immediates (without memory). - Miri effectively ignored the `frame` we are passing to it. And indeed we never want this called on anything but the current frame, also for consistency with the corresponding write hook. So let's restrict `local_to_op` to the current frame. Debuggers/visualizers should be able to use the existing method on `LocalState` that Miri also needs for its provenance visitor. Its name was not sufficiently scary for skipping access hooks, so I also overhauled how we name these "fake"/"ghost" access related APIs.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#160533 (dirfd dir operations (3/4)) - rust-lang/rust#161294 (add crashtests [6/N]) - rust-lang/rust#160392 (library: motor: bump moto-rt ABI ver to 17) - rust-lang/rust#161646 (interpret: fix after_local_read handling) - rust-lang/rust#161682 (Update books) - rust-lang/rust#160819 (Rework `div_ceil` for nonzero integers) - rust-lang/rust#161204 (core: Make funnel shifts panic only if overflow checks are enabled) - rust-lang/rust#161591 (run `classify-runtime-const` test for `f128`) - rust-lang/rust#161680 (renovate: add lockfile update warning) - rust-lang/rust#161709 (Stop rustfmt deleting attributes in fn params)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after_local_readhandling was wrong in two ways:framewe are passing to it. And indeed we never want this called on anything but the current frame, also for consistency with the corresponding write hook.So let's restrict
local_to_opto the current frame.Debuggers/visualizers should be able to use the existing method on
LocalStatethat Miri also needs for its provenance visitor. Its name was not sufficiently scary for skipping access hooks, so I also overhauled how we name these "fake"/"ghost" access related APIs.