Skip to content

Put back tests/rustdoc-gui/search-result-display.goml - #161524

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:flaky-gui-back
Aug 24, 2026
Merged

Put back tests/rustdoc-gui/search-result-display.goml#161524
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:flaky-gui-back

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Aug 22, 2026

Copy link
Copy Markdown
Member

Fixes #152197.

I updated the test I added back in the first commit to remove some potential flaky issues.

The second commit is just a cleanup to reuse the same function to wait for the search results. Like that we only need to change it in one place if we update this.

r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 22, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Urgau
Urgau approved these changes Aug 22, 2026
View reviewed changes

@Urgau Urgau left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI is green

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez

GuillaumeGomez commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

@bors r=urgau

@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 84ba90f has been approved by urgau

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 23, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161524 - GuillaumeGomez:flaky-gui-back, r=u…
ca3ffaf 
…rgau

Put back `tests/rustdoc-gui/search-result-display.goml`

Fixes rust-lang#152197.

I updated the test I added back in the first commit to remove some potential flaky issues.

The second commit is just a cleanup to reuse the same function to wait for the search results. Like that we only need to change it in one place if we update this.

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 23, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161605 - JonathanBrouwer:rollup-JBZhFZL, r=JonathanBro…
817f2d6 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #160302 (target_features: sse (or at least avx2) is incompatible with soft-float ABI)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161586 (miri subtree update)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161166 (add crashtests [5/N], remove unused aux files )
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161605 - JonathanBrouwer:rollup-JBZhFZL, r=JonathanBro…
9cd8e6e 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #160302 (target_features: sse (or at least avx2) is incompatible with soft-float ABI)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161586 (miri subtree update)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161166 (add crashtests [5/N], remove unused aux files )
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 23, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161524 - GuillaumeGomez:flaky-gui-back, r=u…
1787168 
…rgau

Put back `tests/rustdoc-gui/search-result-display.goml`

Fixes rust-lang#152197.

I updated the test I added back in the first commit to remove some potential flaky issues.

The second commit is just a cleanup to reuse the same function to wait for the search results. Like that we only need to change it in one place if we update this.

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 23, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161618 - JonathanBrouwer:rollup-ERimeRR, r=JonathanBro…
6ee39b5 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161592 (core: refactor tests/pattern.rs tests)
 - #161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #159456 (Fix the reporting of layout normalization failures in transmute checks)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161166 (add crashtests [5/N], remove unused aux files )
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - #161601 (Path: use optimized is_empty() method)
 - #161604 (coretests: Add a few tests for backward multibyte predicate)
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 24, 2026
@Zalathar
Rollup merge of rust-lang#161524 - GuillaumeGomez:flaky-gui-back, r=u…
dabba55 
…rgau

Put back `tests/rustdoc-gui/search-result-display.goml`

Fixes rust-lang#152197.

I updated the test I added back in the first commit to remove some potential flaky issues.

The second commit is just a cleanup to reuse the same function to wait for the search results. Like that we only need to change it in one place if we update this.

r? @Urgau
@Zalathar Zalathar mentioned this pull request Aug 24, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
@bors
Auto merge of #161636 - Zalathar:rollup-ZnFNB0u, r=Zalathar
52d4456 
Rollup of 24 pull requests

Successful merges:

 - #161586 (miri subtree update)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161592 (core: refactor tests/pattern.rs tests)
 - #161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - #152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #159456 (Fix the reporting of layout normalization failures in transmute checks)
 - #159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161166 (add crashtests [5/N], remove unused aux files )
 - #161294 (add crashtests [6/N])
 - #161552 (also trigger overflow FCW when going from overflow -> error)
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161580 (Add codegen test for redundant bit mask after a range check)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - #161601 (Path: use optimized is_empty() method)
 - #161604 (coretests: Add a few tests for backward multibyte predicate)
 - #161615 (interpret: make validate_c_variadic_compatible_ty public)
@Zalathar Zalathar mentioned this pull request Aug 24, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
@bors
Auto merge of #161638 - Zalathar:rollup-oG1YjFs, r=Zalathar
04a3cad 
Rollup of 22 pull requests

Successful merges:

 - #161586 (miri subtree update)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161592 (core: refactor tests/pattern.rs tests)
 - #161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - #152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #159456 (Fix the reporting of layout normalization failures in transmute checks)
 - #159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161552 (also trigger overflow FCW when going from overflow -> error)
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161580 (Add codegen test for redundant bit mask after a range check)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - #161601 (Path: use optimized is_empty() method)
 - #161604 (coretests: Add a few tests for backward multibyte predicate)
 - #161615 (interpret: make validate_c_variadic_compatible_ty public)
@rust-bors
rust-bors Bot merged commit ee089bf into rust-lang:main Aug 24, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 24, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
@bors
Unrolled build for #161524 in rollup 161638
d1375ac 
Rollup merge of #161524 - GuillaumeGomez:flaky-gui-back, r=urgau

Put back `tests/rustdoc-gui/search-result-display.goml`

Fixes #152197.

I updated the test I added back in the first commit to remove some potential flaky issues.

The second commit is just a cleanup to reuse the same function to wait for the search results. Like that we only need to change it in one place if we update this.

r? @Urgau
@GuillaumeGomez
GuillaumeGomez deleted the flaky-gui-back branch August 24, 2026 08:42
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Aug 24, 2026
@bors
Auto merge of #161638 - Zalathar:rollup-oG1YjFs, r=Zalathar
a6b3aaa 
Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#161586 (miri subtree update)
 - rust-lang/rust#161187 (add `Complex<T>` layout tests for straightforward targets)
 - rust-lang/rust#161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - rust-lang/rust#161592 (core: refactor tests/pattern.rs tests)
 - rust-lang/rust#161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - rust-lang/rust#152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - rust-lang/rust#155254 (Recover on attribute in use tree)
 - rust-lang/rust#158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - rust-lang/rust#159456 (Fix the reporting of layout normalization failures in transmute checks)
 - rust-lang/rust#159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - rust-lang/rust#160452 (-Ctarget-feature is not unsafe (any more))
 - rust-lang/rust#161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - rust-lang/rust#161552 (also trigger overflow FCW when going from overflow -> error)
 - rust-lang/rust#161569 (Bump cfg_aliases to 0.2.2)
 - rust-lang/rust#161573 (re-bless `pretty-std` on windows)
 - rust-lang/rust#161580 (Add codegen test for redundant bit mask after a range check)
 - rust-lang/rust#161588 (update eyre)
 - rust-lang/rust#161589 (std: reduce visibility of some internal OsStr related types)
 - rust-lang/rust#161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - rust-lang/rust#161601 (Path: use optimized is_empty() method)
 - rust-lang/rust#161604 (coretests: Add a few tests for backward multibyte predicate)
 - rust-lang/rust#161615 (interpret: make validate_c_variadic_compatible_ty public)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 28, 2026
@bors
Auto merge of #161638 - Zalathar:rollup-oG1YjFs, r=Zalathar
b76c0e6 
Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#161586 (miri subtree update)
 - rust-lang/rust#161187 (add `Complex<T>` layout tests for straightforward targets)
 - rust-lang/rust#161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - rust-lang/rust#161592 (core: refactor tests/pattern.rs tests)
 - rust-lang/rust#161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - rust-lang/rust#152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - rust-lang/rust#155254 (Recover on attribute in use tree)
 - rust-lang/rust#158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - rust-lang/rust#159456 (Fix the reporting of layout normalization failures in transmute checks)
 - rust-lang/rust#159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - rust-lang/rust#160452 (-Ctarget-feature is not unsafe (any more))
 - rust-lang/rust#161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - rust-lang/rust#161552 (also trigger overflow FCW when going from overflow -> error)
 - rust-lang/rust#161569 (Bump cfg_aliases to 0.2.2)
 - rust-lang/rust#161573 (re-bless `pretty-std` on windows)
 - rust-lang/rust#161580 (Add codegen test for redundant bit mask after a range check)
 - rust-lang/rust#161588 (update eyre)
 - rust-lang/rust#161589 (std: reduce visibility of some internal OsStr related types)
 - rust-lang/rust#161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - rust-lang/rust#161601 (Path: use optimized is_empty() method)
 - rust-lang/rust#161604 (coretests: Add a few tests for backward multibyte predicate)
 - rust-lang/rust#161615 (interpret: make validate_c_variadic_compatible_ty public)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for spurious rustdoc-gui tests

4 participants

@GuillaumeGomez @rust-log-analyzer @Urgau @rustbot