Implement Hash/PartialEq/Show for PriorityQueue. #16147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it requires sorting the vector, I would say it shouldn't implement these traits. |
|
Yes for now it seems like it may not be worth implementing these traits for a priority queue. It would be quite nice to have show, but the implementations shouldn't bend over too far backwards to be implemented. |
|
Understood. Is it planned that implementation of PriorityQueue will be changing? I don't see any alternative way to do |
|
I am unaware of a planned reimplementation of PriorityQueue. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2024
minor: Don't auto-publish sourcegen Closes rust-lang#16029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit unsure about this since it relies on sorting the underlying vector, an O(n log n) operation. However, I haven't been able to come up with an alternative approach.
cc #15294